Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Tool - Move Viewport label #2387

Merged
merged 9 commits into from
Sep 2, 2024
Merged

New Tool - Move Viewport label #2387

merged 9 commits into from
Sep 2, 2024

Conversation

jmcouffin
Copy link
Contributor

@jmcouffin jmcouffin added the Tools Issues related to pyRevit commands [subsystem] label Sep 2, 2024
sanzoghenzo
sanzoghenzo requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be those that use the pyrevit library properly 😉

As stated in the latest comment, this needs proper error handling.

...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
sanzoghenzo
sanzoghenzo requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll stop here, other thing I would add are just because of personal preference, so they are not needed.

I suppose that after those two changes we could wrap it up

...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
sanzoghenzo
sanzoghenzo requested changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@sanzoghenzo sanzoghenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last one, I promise 😉

...it.tab/Drawing Set.panel/views.stack/Views.pulldown/Move Viewport Label.pushbutton/script.py Outdated Show resolved Hide resolved
@jmcouffin
Copy link
Contributor Author

@sanzoghenzo thanks for the review. Really enjoyed it!

@jmcouffin jmcouffin merged commit 0b2260f into pyrevitlabs:develop Sep 2, 2024
@jmcouffin jmcouffin deleted the tool_move_vp_label branch September 2, 2024 14:06
@jmcouffin jmcouffin restored the tool_move_vp_label branch September 2, 2024 14:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 2, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24246+1410-wip

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24253+1920-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1158-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24254+1351-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24261+0647-wip

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 7, 2024

📦 New work-in-progress (wip) builds are available for 5.0.0.24281+2116-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24293+1618-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24294+1030-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New work-in-progress (wip) builds are available for 5.0.0.24295+0909-wip

@github-actions GitHub Actions
Copy link
Contributor

📦 New public release are available for 5.0.0.24174+2300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanzoghenzo sanzoghenzo sanzoghenzo requested changes

Assignees
No one assigned
Labels
Tools Issues related to pyRevit commands [subsystem]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcouffin @sanzoghenzo