Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Distribution and RandomVariable wrapper classes programmatically #159

Closed
eb8680 opened this issue Jul 14, 2019 · 0 comments · Fixed by #320
Closed

Generate Distribution and RandomVariable wrapper classes programmatically #159

eb8680 opened this issue Jul 14, 2019 · 0 comments · Fixed by #320
Labels
low priority refactor

Comments

@eb8680
Copy link
Member

eb8680 commented Jul 14, 2019 •
edited
Loading

The distribution wrappers in funsor.distributions and the RandomVariable classes in #130 are currently specified manually with a bit of boilerplate on top of the base Distribution class for each distribution of interest.

We should switch to generating them entirely programmatically as in Pyro, which would make it easier to support new distributions and new backends and allow us to reuse more existing infrastructure in eager, like samplers, torch.distributions.constraints, and TransformedDistributions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor funsor.distributions without changing API pyro-ppl/funsor
1 participant
@eb8680