Added dim keyword arg
#2472
Merged
Added dim keyword arg
#2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fritzo
reviewed
May 12, 2020
fritzo
previously approved these changes
May 12, 2020
We need to take `self.dim` into account at the end of `_call`, `_inverse`, and `log_abs_det_jacobian`. As a clarification, the changes to `log_abs_det_jacobian` are needed to perform an "elementwise" summation, where the elements are the samples/batches. This ensures that the transform works with things like `TransformedDistribution` that use the transform's `event_dim` to sum log probabilities from different transformations.
Use of `event_dim` in `log_abs_det_jacobian` allows `Permute` to be compatible with modules such as `TransformedDistribution` that sum log probabilities.
|
@akern40 has found a few bugs in how the dimensions are handled, I'll make the changes plus Fritz' requests |
Additional use of `self.dim`
|
Made the requested changes! |
fritzo
reviewed
May 12, 2020
@stefanwebb do you want to handle that, or I can? |
|
@fritzo @akern40 In the process of adding tests I discovered a number of issues with adding a dim keyword to these classes... I had to rethink how tests were handled for I think in an interface redesign I would make the helper functions to create transforms take an All tests pass now! |
fritzo
previously approved these changes
May 22, 2020
fritzo
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
dimkeyword to thetransforms.Permuteandtransform.AffineCouplingto define which dimension these transforms operate on. As discussed in #2464 this extra flexibility is useful when dealing with matrix/tensor/etc. valued random variables