Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LKJ sample shape bug #2617

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Fix LKJ sample shape bug #2617

merged 1 commit into from
Sep 3, 2020

Conversation

fritzo
Copy link
Member

@fritzo fritzo commented Sep 3, 2020

Fixes #2615

Thanks @PaperclipBadger for diagnosing and suggesting a fix!

Tested

  • added a regression test

fehiepsi
fehiepsi approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @fritzo !

@fehiepsi fehiepsi merged commit a46368d into dev Sep 3, 2020
@fritzo fritzo deleted the fix-2615 branch November 4, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fehiepsi fehiepsi fehiepsi approved these changes

Assignees
No one assigned
Labels
awaiting review bug easy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] Samples from LKJCorrCholesky have the wrong shape
2 participants
@fritzo @fehiepsi