Preserve path to the file when rendering model #3186
Conversation
pyro/infer/inspect.py
Outdated
| @@ -556,7 +556,7 @@ def render_model( | |||
| model: Callable, | |||
| model_args: Optional[Union[tuple, List[tuple]]] = None, | |||
| model_kwargs: Optional[Union[dict, List[dict]]] = None, | |||
| filename: Optional[str] = None, | |||
| filepath: Optional[str] = None, | |||
There was a problem hiding this comment.
Could you keep the signature filename?
There was a problem hiding this comment.
Ok, is it ok now? :)
pyro/infer/inspect.py
Outdated
| suffix = filename.suffix[1:] # remove leading period from suffix | ||
| graph.render(filename.stem, view=False, cleanup=True, format=suffix) | ||
| suffix = Path(filename).suffix[1:] # remove leading period from suffix | ||
| graph.render(os.path.splitext(filename)[0], view=False, cleanup=True, format=suffix) |
There was a problem hiding this comment.
it seems that you need to import os
There was a problem hiding this comment.
Ok, I re-added it. Not sure why it was not there
There was a problem hiding this comment.
could you run make format to fix the lint issue?
There was a problem hiding this comment.
@fehiepsi Ops, sorry I am a little beginner. I am not sure what make format means here. Is it another package?
I did run pylint over the script with this output:
************* Module pyro.infer.inspect
inspect.py:1:0: C0114: Missing module docstring (missing-module-docstring)
inspect.py:15:0: R0402: Use 'from pyro import poutine' instead (consider-using-from-import)
inspect.py:26:0: C0116: Missing function or method docstring (missing-function-docstring)
inspect.py:37:4: C0103: Variable name "fn" doesn't conform to snake_case naming style (invalid-name)
inspect.py:39:8: C0103: Variable name "fn" doesn't conform to snake_case naming style (invalid-name)
inspect.py:46:0: C0115: Missing class docstring (missing-class-docstring)
inspect.py:61:0: R0914: Too many local variables (24/15) (too-many-locals)
inspect.py:183:20: E1102: poutine.trace is not callable (not-callable)
inspect.py:204:12: C0103: Variable name "u" doesn't conform to snake_case naming style (invalid-name)
inspect.py:206:16: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
inspect.py:211:8: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
inspect.py:212:12: C0103: Variable name "u" doesn't conform to snake_case naming style (invalid-name)
inspect.py:212:15: C0103: Variable name "p" doesn't conform to snake_case naming style (invalid-name)
inspect.py:221:8: C0103: Variable name "d" doesn't conform to snake_case naming style (invalid-name)
inspect.py:223:12: C0103: Variable name "u1" doesn't conform to snake_case naming style (invalid-name)
inspect.py:223:16: C0103: Variable name "p1" doesn't conform to snake_case naming style (invalid-name)
inspect.py:224:16: C0103: Variable name "u2" doesn't conform to snake_case naming style (invalid-name)
inspect.py:224:20: C0103: Variable name "p2" doesn't conform to snake_case naming style (invalid-name)
inspect.py:61:0: R0912: Too many branches (13/12) (too-many-branches)
inspect.py:285:20: E1102: poutine.trace is not callable (not-callable)
inspect.py:323:12: C0103: Variable name "p" doesn't conform to snake_case naming style (invalid-name)
inspect.py:323:15: C0103: Variable name "pv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:324:12: C0103: Variable name "pv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:325:16: C0103: Variable name "q" doesn't conform to snake_case naming style (invalid-name)
inspect.py:325:19: C0103: Variable name "qv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:326:16: C0103: Variable name "qv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:323:12: W0612: Unused variable 'p' (unused-variable)
inspect.py:350:19: C0103: Argument name "fn" doesn't conform to snake_case naming style (invalid-name)
inspect.py:358:0: R0914: Too many local variables (19/15) (too-many-locals)
inspect.py:375:12: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:382:8: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:358:0: R0912: Too many branches (17/12) (too-many-branches)
inspect.py:449:21: W0612: Unused variable 'value' (unused-variable)
inspect.py:466:0: R0914: Too many local variables (27/15) (too-many-locals)
inspect.py:475:8: W0621: Redefining name 'graphviz' from outer scope (line 21) (redefined-outer-name)
inspect.py:475:8: C0415: Import outside toplevel (graphviz) (import-outside-toplevel)
inspect.py:476:4: C0103: Variable name "e" doesn't conform to snake_case naming style (invalid-name)
inspect.py:507:12: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:542:12: C0103: Variable name "rv" doesn't conform to snake_case naming style (invalid-name)
inspect.py:466:0: R0912: Too many branches (16/12) (too-many-branches)
inspect.py:525:16: W0612: Unused variable 'plate2' (unused-variable)
inspect.py:556:0: R0913: Too many arguments (6/5) (too-many-arguments)
-----------------------------------
Your code has been rated at 8.00/10
It does not point anything at lines 607-610, so I assumed it was ok ...
There was a problem hiding this comment.
I think you can go to the cloned numpyro folder and run make format. If you are using windows, probably running black *.py pyro and isort . will work. You need to install both black and isort to run those commands (pip install black isort)
There was a problem hiding this comment.
Thanks for the info! I am in Linux, so I simply pip installed black isort as you mentioned and then, I have just run black over the entire pyro repository as black pyro/*.py. It announced some changes and that should be it? I also run isort pyro/*.py just in case
The command make format does not work (perhaps I need to install some additional stuff?), but the black and isort worked.
There was a problem hiding this comment.
I guess the line is too long, you can do
filepath = os.path.splitext(filename)[0]
graph.render(filepath, ...)
There was a problem hiding this comment.
Okey , dok, thanks for the patience, done!
There was a problem hiding this comment.
Thanks, CI passed. It seems that you are using a black version different from CI.
There was a problem hiding this comment.
Perhaps, I am using:
black, 23.1.0 (compiled: yes)
Python (CPython) 3.8.13
No description provided.