-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI with PyTorch 2.0 #3192
Run CI with PyTorch 2.0 #3192
Conversation
Seems like #3212 fixed most of the failures we saw before. From the logs, the only remaining failures are:
|
@eb8680 what/where's the rejector error? i don't see anything informative in the logs... |
In the
I don't see a more detailed traceback further up in the log, so I'm not quite sure what's going on. |
i see i think we can safely declare that and the stable errors as failing due to flakiness resulting from small numerical differences in ops |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@fritzo i made the rejector test pass and some of the stable tests but some of the stable tests are still failing... maybe you can take a look? |
@martinjankowiak that would be fine with me. |
I'm fine xfailling. The Stable tests work on my machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge when tests pass.
I'd like to merge #3220 before releasing.
This is a dummy PR to trigger a test run with the new PyTorch 2.0 release and see what breaks.
Log from running
pytest -v --stage=unit --tb=no -n auto
on my local machine (Ubuntu 22.04, Python 3.10.9,torch==2.0.0
):