-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix about device of subsample in subsample_messenger.py #3195
Conversation
i'm assuming you're using a plate and using |
I have specified the |
Here are some error information:
But It works fine when I tried trace the model shape
|
@hjnnjh can you please provide a minimal runnable script / code snippet that demonstrates this error? |
Hi @hjnnjh thanks for the fix! I think it's a little dangerous to decide based on - new_value = value.index_select(dim, self._indices)
+ new_value = value.index_select(dim, self._indices.to(value.device)) EDIT looks like the lint errors are due to |
I'm busy building my model the past few days. I'll provide a minimal runnable script soon. |
Thanks for your reply! I think this is a better solution. It works fine now. |
…bsample_messenger.py
@hjnnjh looks good. Can you just try running |
I just reformatted |
@fritzo Hello, can this PR be merged? |
I made the following changes on my device. Currently works fine. Since the whole Pyro project is very complex, I am not sure where the source of the bug is. I hope you can fix this bug soon.