Type annotate pyro.poutine.runtime
#3288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ordabayevy
changed the title
pyro/poutine/runtimepyro.poutine.runtime
ordabayevy
commented
Oct 30, 2023
| @@ -112,7 +112,7 @@ def get_posterior( | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def upstream_value(self, name: str) -> torch.Tensor: | |||
| def upstream_value(self, name: str): | |||
There was a problem hiding this comment.
Temporarily removed the return type (changed to Any) so that mypy wouldn't complain. Will be fixed in a later PR.
fritzo
approved these changes
Nov 1, 2023
| # the global pyro stack | ||
| _PYRO_STACK = [] | ||
| _PYRO_STACK: List[Messenger] = [] |
| """ | ||
| Allocate a dimension to an :class:`plate` with given name. | ||
| Dim should be either None for automatic allocation or a negative | ||
| integer for manual allocation. | ||
| """ | ||
| if name in self._stack: | ||
| raise ValueError('duplicate plate "{}"'.format(name)) | ||
| raise ValueError(f"duplicate plate '{name}'") |
There was a problem hiding this comment.
No need to change, but I've been using the notation f"duplicate plate {name!r}" which I find easier to read.
| ignore_errors = True | ||
| warn_unused_ignores = True |
There was a problem hiding this comment.
Can we add warn_unused_ignores to the top level [mypy] config? I've found that some # type: ignores mask real errors on the same line, so I've started using warn_unused_ignores globally, but maybe this practice is too pedantic for a user base with diverse mypy versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.