Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalize Access class #10

Closed
knaaptime opened this issue Aug 2, 2020 · 4 comments
Closed

capitalize Access class #10

knaaptime opened this issue Aug 2, 2020 · 4 comments

Comments

@knaaptime
Copy link
Member

since we want to ensure pep-8 compatibility across the subpackages, could we capitalize the Access class?

@JamesSaxon
Copy link
Contributor

Sure, we can do this, but it will take me a few days to get to this. Vidal brought this up earlier.

@JamesSaxon
Copy link
Contributor

Hey, @knaaptime --- yes that has been on my mind.

@jkoschinsky and I had said that @vidal-anguiano would look at this, but it has been some time. @vidal-anguiano, do you expect to have time for this before January?

@knaaptime
Copy link
Member Author

sweet! (sorry to pester :))

i've got some other maintenance to do for other packages before the meta release as well, so I'm happy to help put the PR together too, if that's the path of least resistance

@vidal-anguiano
Copy link
Contributor

@knaaptime, @jkoschinsky and @JamesSaxon , apologies for the delay on this, I've made the case changes to both the Access and Datasets classes, and created a pull request. Let me know if you have any feedback or see anything I might have missed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants