Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no varnames in Moran_BV_matrix #22

Closed
slumnitz opened this issue Jul 18, 2018 · 3 comments
Closed

no varnames in Moran_BV_matrix #22

slumnitz opened this issue Jul 18, 2018 · 3 comments

Comments

@slumnitz
Copy link
Member

slumnitz commented Jul 18, 2018

Moran_BV_matrix object takes varnames as input, but this argument does not seem to be used anywhere in the function.

For labeling moran_facette() plots (starting to prototype facets), it would be great to either include this list as an attribute of the Moran-BV_matrix Object, or even allow for varnames input in the Moran_BV Object.

What do you think @sjsrey @darribas @ljwolf?

@ljwolf
Copy link
Member

ljwolf commented Jul 18, 2018

I think it'd be great to store the varnames on the object and use them when needed. By default these should be ['x{}'.format(i) for i in range(p)] for an (n,p) input matrix.

@slumnitz
Copy link
Member Author

slumnitz commented Jul 18, 2018

@ljwolf thank you for the tip: #23 should deal with this

@slumnitz
Copy link
Member Author

slumnitz commented Aug 9, 2018

This can be closed since #23 got merged.

@slumnitz slumnitz closed this as completed Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants