Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

W.symmetrize(inplace=False) resets id order #136

Closed
ljwolf opened this issue Feb 11, 2019 · 1 comment · Fixed by #137
Closed

W.symmetrize(inplace=False) resets id order #136

ljwolf opened this issue Feb 11, 2019 · 1 comment · Fixed by #137

Comments

@ljwolf
Copy link
Member

ljwolf commented Feb 11, 2019

If you try to create a symmetric copy of a KNN weight where the id_order is customized, the id_order will reset because of this.

When inplace=True, the method works as intended.
@ljwolf
Copy link
Member Author

ljwolf commented Feb 11, 2019 •
edited
Loading

also, is it just me, or does ids not do anything in W.__init__? I only see reference to id_order in that initialization.

@ljwolf ljwolf mentioned this issue Feb 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make id_order propagate through symmetrize(inplace=False) ljwolf/libpysal
1 participant
@ljwolf