build_lattice_shapefile swapped arguments

[renanxcortes]

I was building regular rectangular lattices in one my applications and realized that the arguments of
pysal.weights.build_lattice_shapefile is swapped as follows:

The nrows gives the number of columns and vice-versa. The reproducible code would be (in a Jupyter notebook):

import pysal as ps
import geopandas as gpd

%matplotlib inline
ps.weights.build_lattice_shapefile(nrows = 2, ncols = 6, outFileName = 'reg_lat.shp')
lat_2_6 = gpd.read_file('reg_lat.shp')
lat_2_6.plot(edgecolors = 'black')

Best,
Renan

[jGaboardi]

This appears to have already been resolved. See this gist.

[renanxcortes]

Ow, yes, you're right! Thank you for closing this! This was resolved in: e2609a9