Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] should weights.util.get_ids() also accept a geodataframe? #97

Closed
jGaboardi opened this issue Aug 15, 2018 · 4 comments
Closed

[ENH] should weights.util.get_ids() also accept a geodataframe? #97

jGaboardi opened this issue Aug 15, 2018 · 4 comments
Assignees
@jGaboardi
Labels
enhancement needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap

Comments

@jGaboardi
Copy link
Member

Would we like to have get_ids(shapefile, idVariable) in libpysal.weights.util also accept a geopandas.GeoDataFrame as a valid arg for shapefile? If so, I am willing to put a PR together.
@sjsrey
Copy link
Member

sjsrey commented Aug 15, 2018

I think this is a good idea.

@jGaboardi
Copy link
Member Author

the issue will be resolved in #101

@ljwolf ljwolf added the needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap label Aug 17, 2018
@jGaboardi
Copy link
Member Author

@ljwolf are there any other specific tests I can put together other than the one I already included?

@ljwolf
Copy link
Member

ljwolf commented Oct 7, 2018

resolved by #101

@ljwolf ljwolf closed this as completed Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jGaboardi jGaboardi

Labels
enhancement needs testing a pull request which needs testing added, or a bug/rough edge which exposes a functional testing gap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjsrey @ljwolf @jGaboardi