Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intensity estimates for new ripley functions are very incorrect sometimes #55

Closed
ljwolf opened this issue Jun 1, 2020 · 1 comment
Closed
Assignees

Comments

@ljwolf
Copy link
Member

ljwolf commented Jun 1, 2020

I noticed this problem when writing tests for the new numpy-based performant Ripley statistics. When using a shapely polygon's convex hull, I was getting basically the correct intensity, but when I was using scipy, I was getting extreme overestimates of the intensity.

I narrowed it down to an issue with how scipy.spatial.ConvexHull.area works scipy/scipy#12290.

Depending on the fix there we need to either:

  1. move to using hull.volume when getting the area from a scipy convex hull if upstream decides to adopt docstring clarifications
  2. keep using area if upstream decides to adopt the proposed changes for area/volume of 2-d shapes.
@ljwolf ljwolf self-assigned this Jun 1, 2020
@ljwolf
Copy link
Member Author

ljwolf commented Jun 1, 2020

I moved to using volume until I hear from scipy.

@ljwolf ljwolf closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant