Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update plot_spatial_weights for new libpysal api #174

Open
knaaptime opened this issue Jan 13, 2023 · 8 comments
Open

update plot_spatial_weights for new libpysal api #174

knaaptime opened this issue Jan 13, 2023 · 8 comments

Comments

@knaaptime
Copy link
Member

when the libpysal change goes live (libpysal.weights.W(...use_index=True) it will break the spatial weights plotting function

@martinfleis
Copy link
Member

We wanted to refactor that anyway and merge the plotting method we have here with the one over in lib anyway. So it may actually be a candidate for a quick-ish PR.

@knaaptime
Copy link
Member Author

while we're at it, one thing it would be nice to add is auto ability to scale linewidths by weight value for nonbinary weights

@knaaptime
Copy link
Member Author

also maybe an interactive analogue

@martinfleis
Copy link
Member

An easy way to do those would be to create a GeoSeries from the links and use geopandas plot and explore methods but it means one more copy of the data as an intermediate step.

@knaaptime
Copy link
Member Author

thats what i had in mind. And maybe @walkerke would be willing to contribute his interactive LISA code?

@martinfleis
Copy link
Member

I thought that's just explore over LISA labels, no?

@knaaptime
Copy link
Member Author

yeah pretty much. just a function to wrap the labels and hit explore

@walkerke
Copy link

Looking through splot I think an interactive analogue to the methods that wraps .explore() would be pretty useful. Happy to take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants