Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize regression approach #36

Closed
knaaptime opened this issue Dec 5, 2019 · 1 comment
Closed

generalize regression approach #36

knaaptime opened this issue Dec 5, 2019 · 1 comment
Assignees

Comments

@knaaptime
Copy link
Member

knaaptime commented Dec 5, 2019

currently, the function that does the heavy lifting in the regression approach is hardcoded to use pixel counts, but that precludes the ability to specify more complex models (e.g. log-transforming the pixel counts, adding interactions, or including more input data).

instead, we should allow the function to take a patsy-style model formulation as a string instead of assuming we know what the user wants in this line

@knaaptime knaaptime self-assigned this Dec 5, 2019
@knaaptime
Copy link
Member Author

resolved by #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant