MacOS imag-preview #44

Jac-Zac · 2021-02-27T21:35:14Z

Just to make you aware of this, preview of thumbnails doesn't work on macOS. The script download the images were it should, but it doesn't show them. It looks like the problem has to do with Überzug. I also tried to run fontpreview-ueberzug which won't work either. But I might also be wrong so if other people have mac they might be helpful. I also tried to used Überzug to preview images in ranger and It doesn't work. In ranger they use a preview for that works with iTerm terminal emulator. An example is imgcat

westofer · 2021-02-28T04:36:58Z

can you post the output of ueberzug version?

mine is 18.1.9

Jac-Zac · 2021-02-28T09:04:06Z

ueberzug version

Same... Does it work for you ? @westofer

westofer · 2021-02-28T11:14:06Z

yes it works, are you using fish by any chance? becuase it doesn't work in fish for me

@Jac-Zac

Jac-Zac · 2021-02-28T15:18:26Z

yes it works, are you using fish by any chance? becuase it doesn't work in fish for me

@Jac-Zac

I’m using zsh maybe we can have a discord server and talk there instead of just messaging ? @westofer

westofer · 2021-02-28T15:24:39Z

sure @Jac-Zac

Jac-Zac · 2021-02-28T15:47:45Z

https://discord.gg/FNym2zpK This is the discord server if we find helpful we might also expand it in the future and add it to README.md
@westofer

khuei · 2021-03-03T14:01:29Z

Ueberzug relied on X11 so it wouldn't work in system that doesn't use X11

I know it's late but this might be helpful to some people who have this issue

pystardust · 2021-03-03T16:01:54Z

Yes people on wayland are also having this issue. If anybody knows a terminal viewer that work on wayland + mac do let us know.

cybardev · 2021-03-03T18:47:51Z

Yes people on wayland are also having this issue. If anybody knows a terminal viewer that work on wayland + mac do let us know.

Would w3m work?

tinywrkb · 2021-03-03T19:45:12Z

@pystardust Ranger file manager has iTerm2 support for image previews, so maybe look at what it's doing. I don't have a Mac but it worked for me with Alacritty when pulling in the graphics PR that adds iTerm2 protocol & libsixel (though it looks like it won't be merged as it is).
Ranger also has support for the image protocol of Kitty, and Kitty is also cross-platform.

khuei · 2021-03-04T02:52:11Z

I also like the way neofetch provides different image preview options for the user to choose from. I understand it would take a long time to implement, but it would be a neat and cool feature.

dimitarvp · 2021-03-21T03:31:54Z

My ueberzug is also at 18.1.9 and I update ytfzf daily with a cron job. I am on the latest macOS (11.2.3 as of today) and for me image previews don't work either. Tried inside iTerm2 and Alacritty, no dice in both.

I am not very keen on using a non-upstream version of Alacritty for now but might be willing to try pulling the above-mentioned graphics PR.

Is there anything us the macOS users can do to have the images previewed in our terminals?

cybardev · 2021-03-21T04:48:24Z

Is there anything us the macOS users can do to have the images previewed in our terminals?

Try to change the code in ytfzf a bit to use iTerm2's own image renderer.

Tbh even I'd like if there were options like neofetch - I'd use my kitty terminal's internal renderer.

Jac-Zac · 2021-03-21T09:56:58Z

I think we should do it like you said using iTerm's own image viewer like they have done here. This is the iTerm page. But you can't just use the imgcat script because fzf will just output the long string. If anybody has some ideas on what we can do I would be wiling to work together to try to solve it maybe on discord

khuei · 2021-03-22T15:17:11Z

I will try to implement different image viewers similar to neofetch, so user can choose whichever one they like. However, I think we should try to get w3m working as an alternative to ueberzug, since w3m should work on all system.

pystardust · 2021-03-22T16:30:21Z

Yes I have tried w3mimg, it works well only with some terminals(urxvt)
Run this scirpt in a directory with images, do not give it any arguments.
You would need to give the path to your w3mimgdisplay binary that would be usually in /usr/lib/w3m/ depending on your distro. I have copied mine to my ~/.bin/ here

#!/bin/sh

path_to_w3mimg=~/.bin/w3mimgdisplay

showimage () {
	printf '%b\n3;\n4\n' "0;1;20;20;$((FZF_PREVIEW_COLUMNS *55/10));$((FZF_PREVIEW_COLUMNS *55/10));;;;;$1"  | "$path_to_w3mimg" &>/dev/null 
}

if [ "$#" -eq 1 ]; then
	showimage "$1"
else
	fzf --preview "sh $0 {}" --preview-window "left"
fi

pystardust · 2021-03-22T16:30:59Z

If this seems fine, then we could add this feature in ytfzf

khuei · 2021-03-26T13:05:36Z

Can someone with macOS test this script?

dimitarvp · 2021-03-26T13:12:07Z

@Z5483 Which script exactly? The one that uses w3mimgdisplay? I am not even sure how to install it on a Mac.

khuei · 2021-03-26T13:14:28Z

yes, the w3mdisplay script @pystardust posted few days ago.

#!/bin/sh

path_to_w3mimg=~/.bin/w3mimgdisplay

showimage () {
        printf '%b\n3;\n4\n' "0;1;20;20;$((FZF_PREVIEW_COLUMNS *55/10));$((FZF_PREVIEW_COLUMNS *55/10));;;;;$1"  | "$path_to_w3mimg" &>/dev/null 
}

if [ "$#" -eq 1 ]; then
        showimage "$1"
else
        fzf --preview "sh $0 {}" --preview-window "left"
fi

copy fhe above into a file and make the file executable using chmod +x. Then, you should be able to run the script.

dimitarvp · 2021-03-26T13:20:11Z

I can't run that script because I have no ~/.bin/w3mimgdisplay file. Doing brew search w3mimgdisplay didn't yield any results either. Any quick pointers how to install that binary? A quick search on the net doesn't show it as a standalone package for Mac.

westofer · 2021-03-26T13:20:44Z

install w3m

dimitarvp · 2021-03-26T13:23:37Z

@westofer Installed it via brew install w3m but still no w3mimgdisplay binary in its directory tree -- or anywhere in $PATH. Only w3m and w3mman.

westofer · 2021-03-26T13:26:42Z

find / -name 'w3mimgdisplay'

mine was in /usr/lib/w3m/w3mimgdisplay

dimitarvp · 2021-03-26T13:33:39Z

Already did that. It's nowhere to be found. I don't think the homebrew package includes it.

khuei · 2021-03-26T13:48:17Z

it might be related to this issue tats/w3m#95

dimitarvp · 2021-03-26T13:58:43Z

OK, cloned, compiled with the right options, changed the path in the above script, ran it in both iTerm2 and Alacritty (in a directory that has images in it), moved with the keyboard arrows until I got to an image in the file list -- nothing appears on the left. Also waited for fc-cache to finish (it spiked for several seconds) just to make sure.

I am seeing a blank black pane on the left. It has borders but no content.

Also pressed ENTER when selecting an image -- I only get the image file name as an output of the script.

I am new to w3m. Is there a way to test image showing in the terminal in isolation like with imgcat? Just running w3mimgdisplay image.jpeg does nothing.

dimitarvp · 2021-03-26T14:23:20Z

Another thing. Somewhere along the whole stuff an XQuartz installer popped up in the background which I didn't notice. I went through its installation and logged out and back in as the installer requested.

Results are the same. Maybe w3m has to be reconfigured and recompiled now that XQuartz is in place?

khuei · 2021-03-26T15:09:34Z

Maybe w3m has to be reconfigured and recompiled now that XQuartz is in place?

This is outside of my knowledge since I'm not familiar with macOS. I think unlikely that you will have to recompile w3m since it does not depend neither XQuartz or Xlib.

ran it in both iTerm2 and Alacritty (in a directory that has images in it), moved with the keyboard arrows until I got to an image in the file list -- nothing appears on the left

I will take at a look at the w3mdisplay script this weekend.

khuei · 2021-03-30T01:41:43Z

I can confirm that the w3mdisplay script results in the image flickers then disappears

pystardust · 2021-04-08T18:54:55Z

Could someone with a mac try using iTerms image viewer and make a script that would display an image given as input, with the give height and width at a given coordinate

cheemeng · 2021-04-24T19:20:16Z

Instead of specifically relying on iTerm's imgcat (you can't even reposition the image, and there might be users of other terminals too such as Kitty or Wez's), perhaps you could take a look at timg?

It plays nicely with fzf too using the --preview parameter (might help you simplify maintenance of your menu system), heck you can even have timg output thumbnails into files instead of display, and simply cat the files out later.

Euro20179 · 2021-05-19T17:45:42Z

it is hard to implement image viewers that don't use ascii characters because of the way fzf's preview works, it basically only accepts ascii, the reason ueberzug works is because it's it's own window, w3m could possibly work, but whenever you try to use it the image is only on the screen for about .2 seconds.

viewers i tried that didn't work (all of which are proper image viewers)

kitty/icat
tycat
w3m
lsix/sixel

until something gets implemented for all OS/display servers, i'd recommend chafa as it seems to be the best, but it's your choice

Euro20179 · 2021-10-22T16:49:17Z

I have implemented w3m, see my latest comments on #64.

arisolt · 2023-04-03T07:01:05Z

With kitty support broken/removed and sixel not supported by fzf is there any option left for Mac users to preview images in the terminal?

jstkdng · 2023-05-02T23:03:36Z

Hey everyone, I have been developing this project, https://github.com/jstkdng/ueberzugpp, it is a drop in replacement for ueberzug but with aditional features such as sixel, kitty and iterm2 support. @Euro20179 has kindly added support for my project in ytfzf development branch and so far under linux all 4 outputs work (x11, kitty, sixel, iterm2).
U++ should also work in MacOS but I have not being able to test it since I don't own any apple devices. I'd be happy to help if someone is willing to test U++ in MacOS and finally close this issue.

Jac-Zac · 2023-05-04T20:41:31Z

Trying to run the development branch to test it on mac gives me this error:

./ytfzf       
./ytfzf: line 3109: syntax error near unexpected token `;;'
./ytfzf: line 3109: `		youtube-dl) ${ytdl_path} -F "$1" ;;'```

Euro20179 · 2023-05-04T21:04:08Z

What is the output of ls -l /usr/bin/sh (im interested in what it's linking to)

Jac-Zac · 2023-05-04T22:05:43Z

I get this:

ls -l /usr/bin/sh 
lsd: /usr/bin/sh: No such file or directory (os error 2).```
In general though I use zsh:

echo $SHELL
/bin/zsh
``

Indeed by running: dash ytfzf it works

Euro20179 · 2023-05-04T22:08:28Z

~~Oh interesting, since /usr/bin/sh doesn't exist, it's probably running ytfzf with zsh which is unsupported.~~
Actually, ytfzf is using /usr/bin/env sh, i'm assuming the env path doesn't exist, i'll have to fix that.

I'll look into that later, for now run dash ytfzf -t -T iterm2 search, and see if the thumbnails work.

Jac-Zac · 2023-05-04T22:24:40Z

Mmmm maybe it is just my problem and for some reason my sh is still liking to zsh and it should link to something like dash or bash. If I run it as you said it runs but the previewer doesn't work since it still try to run with zsh. If I change the shabang from sh to dash I get it to work though

Euro20179 · 2023-05-04T22:28:43Z

Mmmm maybe it is just my problem and for some reason my sh is still liking to zsh

Nah, ls said that /usr/bin/sh doesn't exist in the first place, it's not linking to anything.

ytfzf uses /usr/bin/env sh as the shebang, try changing it to /bin/env sh, if that works I'll probably change the shebang to that.

And just to confirm, thumbnails do work with iterm2?

Jac-Zac · 2023-05-04T22:32:22Z

Oky but: /usr/bin/env does and when I run /usr/bin/env sh I'm quite sure I get a zsh shell so that is the problem. As I said using /usr/bin/env dash I get it to work on the other hand this path doesn't exist: /bin/env

Jac-Zac · 2023-05-04T22:34:11Z

About the thumbnails not really and I'm not really sure what was the porblem since I get this:

and it seems to be stuck

Jac-Zac · 2023-05-04T22:34:58Z

I have also tried with: ueberzug I do not get any error but I get the same behavior

Euro20179 · 2023-05-04T22:38:26Z

Oky but: /usr/bin/env does and when I run /usr/bin/env sh I'm quite sure I get a zsh shell so that is the problem. As I said using /usr/bin/env dash I get it to work on the other hand this path doesn't exist: /bin/env

Oh, nvm then.

I have also tried with: ueberzug I do not get any error but I get the same behavior

Ueberzug wont work, linux only,

apparently iterm2 is not in the newest version of ueberzugpp, so it needs to be compiled manually if your up for that, if you're not up for it, it's all good.

Jac-Zac · 2023-05-04T22:41:59Z

What exactly should I do ? btw I meant that I have tried with ueberzugcpp not ueberzug since I have that in my path with the name ueberzug

Euro20179 · 2023-05-04T22:47:47Z

in my path with the name ueberzug

ytfzf checks specifically if you have ueberzugpp as a binary, so I would create a link called ueberzugpp to ueberzug, make sure you have ueberzugpp saved as ueberzug and ueberzugpp, as they're both used in ytfzf (I may change this later).

Then run ytfzf -t -T iterm2 search

If that doesn't work you could try the following:

ueberzugpp needs to be compiled manually (until iterm2 gets put into a release), as instructed on the ueberzugpp readme, make sure to disable x11 support.

Put the binary, and a copy named ueberzug somewhere in path

run ytfzf -t -T iterm2 search in the iterm2 terminal, theoretically images should show up

jstkdng · 2023-05-04T23:27:01Z

X11 support should work in theory since MacOS has xquartz, the terminal also has to run through xquartz though. The same reason x11 works in wayland, only if the terminal is also running through xwayland.

jstkdng · 2023-05-05T05:33:38Z

Managed to get a macos vm running and pushed a temporary fix for U++, turns out MacOS doesn't support procfs and uses different directories for pseudo-terminals, gonna have to work around that. It works at least.

Sometimes this error appears though.

Euro20179 · 2023-05-05T05:37:57Z

It works at least.

Nice!

As for the error, it might've just failed to download the image.

Jac-Zac · 2023-05-05T07:23:33Z

Ohhh sorry, It also works for me, but yesterday was very late and I made a symlink to ueberzugcpp instad of ueberzugpp my fault 🤦

Euro20179 · 2023-05-05T13:17:21Z

I made a symlink to ueberzugcpp instad of ueberzugpp my fault

Lol, glad it works though!

jstkdng · 2023-05-05T13:35:52Z

nice, I also fixed the proc issue. Now I think some more testing could be done by other users? I'll try to create a homebrew package.

jstkdng · 2023-05-07T21:47:15Z

I have created a release with iterm2 and macos support. I've also created a homebrew script but it will take some time before it is included in homebrew-core.
I guess this could be closed unless there are other issues.

Euro20179 · 2023-05-07T23:18:26Z

I guess this could be closed unless there are other issues.

Once I release 2.6.0 I will close this (assuming there are no other issues).

Euro20179 mentioned this issue May 19, 2021

feat: more ways to view thumbnails #254

Merged

Euro20179 mentioned this issue Dec 26, 2021

User configurable thumbnail viewer #425

Closed

Euro20179 added the thumbnails label Feb 2, 2022

Euro20179 closed this as completed May 12, 2023

MacOS imag-preview #44

MacOS imag-preview #44

Comments

Jac-Zac commented Feb 27, 2021

westofer commented Feb 28, 2021

Jac-Zac commented Feb 28, 2021 • edited Loading

westofer commented Feb 28, 2021 • edited Loading

Jac-Zac commented Feb 28, 2021 • edited Loading

westofer commented Feb 28, 2021

Jac-Zac commented Feb 28, 2021 • edited Loading

khuei commented Mar 3, 2021

pystardust commented Mar 3, 2021

cybardev commented Mar 3, 2021

tinywrkb commented Mar 3, 2021

khuei commented Mar 4, 2021

dimitarvp commented Mar 21, 2021

cybardev commented Mar 21, 2021 • edited Loading

Jac-Zac commented Mar 21, 2021

khuei commented Mar 22, 2021

pystardust commented Mar 22, 2021

pystardust commented Mar 22, 2021

khuei commented Mar 26, 2021 • edited Loading

dimitarvp commented Mar 26, 2021

khuei commented Mar 26, 2021 • edited Loading

dimitarvp commented Mar 26, 2021 • edited Loading

westofer commented Mar 26, 2021

dimitarvp commented Mar 26, 2021

westofer commented Mar 26, 2021 • edited Loading

dimitarvp commented Mar 26, 2021

khuei commented Mar 26, 2021

dimitarvp commented Mar 26, 2021 • edited Loading

dimitarvp commented Mar 26, 2021

khuei commented Mar 26, 2021

khuei commented Mar 30, 2021

pystardust commented Apr 8, 2021

cheemeng commented Apr 24, 2021 • edited Loading

Euro20179 commented May 19, 2021 • edited Loading

Euro20179 commented Oct 22, 2021

arisolt commented Apr 3, 2023

jstkdng commented May 2, 2023

Jac-Zac commented May 4, 2023

Euro20179 commented May 4, 2023 • edited Loading

Jac-Zac commented May 4, 2023 • edited Loading

Euro20179 commented May 4, 2023 • edited Loading

Jac-Zac commented May 4, 2023

Euro20179 commented May 4, 2023 • edited Loading

Jac-Zac commented May 4, 2023

Jac-Zac commented May 4, 2023

Jac-Zac commented May 4, 2023

Euro20179 commented May 4, 2023

Jac-Zac commented May 4, 2023 • edited Loading

Euro20179 commented May 4, 2023 • edited Loading

jstkdng commented May 4, 2023

jstkdng commented May 5, 2023

Euro20179 commented May 5, 2023

Jac-Zac commented May 5, 2023 • edited Loading

Euro20179 commented May 5, 2023

jstkdng commented May 5, 2023

jstkdng commented May 7, 2023

Euro20179 commented May 7, 2023

Jac-Zac commented Feb 28, 2021 •

edited

Loading

westofer commented Feb 28, 2021 •

edited

Loading

Jac-Zac commented Feb 28, 2021 •

edited

Loading

Jac-Zac commented Feb 28, 2021 •

edited

Loading

cybardev commented Mar 21, 2021 •

edited

Loading

khuei commented Mar 26, 2021 •

edited

Loading

khuei commented Mar 26, 2021 •

edited

Loading

dimitarvp commented Mar 26, 2021 •

edited

Loading

westofer commented Mar 26, 2021 •

edited

Loading

dimitarvp commented Mar 26, 2021 •

edited

Loading

cheemeng commented Apr 24, 2021 •

edited

Loading

Euro20179 commented May 19, 2021 •

edited

Loading

Euro20179 commented May 4, 2023 •

edited

Loading

Jac-Zac commented May 4, 2023 •

edited

Loading

Euro20179 commented May 4, 2023 •

edited

Loading

Euro20179 commented May 4, 2023 •

edited

Loading

Jac-Zac commented May 4, 2023 •

edited

Loading

Euro20179 commented May 4, 2023 •

edited

Loading

Jac-Zac commented May 5, 2023 •

edited

Loading