-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove boxed and provide --boxed via pytest-forked #1
Conversation
should i merge it? |
its not for merge yet |
Not sure if you plan new major release but if not maybe would be nice to keep --boxed for backward compatibility with deprecation warning instead? |
Suggestion: Add
Hmmm good point. Perhaps we should add a warning in |
the current plan is to finish the merge of pytest-cache into pytest and perhaps introduce a looponfail mode there if thats done im thinking of releasing a pytest-xdist 2.0 that removes both boxed and looponfail |
@RonnyPfannschmidt sounds like a good plan, +1 |
Yep, sounds good! 👍 |
Sorry for jumping on this one, but thats where google left me... If --boxed is deprecated, is there a new functionality replacing it ? How can I, as a user, enforce process isolation when testing ? Is there a link to the documentation somewhere ? I am in need of this feature, and the only option I found so far are --boxed for py.test or nosepipe for nose... Thanks for any info. |
@asmodehn the change will be accompanied with releasing a pytest-boxed plugin as a dependency - at a later point in time we intend to support it natively in xdist starting one node per collected item, potentially running a different node for plain collection |
Fix for eventname test
a69969a
to
56d62c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, just some minor docs adjustments IMO. 👍
changelog/1.removal
Outdated
@@ -0,0 +1 @@ | |||
remove the implementation of "boxed" and use pytest-forked for providing ``--boxed`` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
``--boxed`` functionality has been moved to a separate plugin, `pytest-forked <https://github.com/pytest-dev/pytest-forked>`_. This release now depends on `` pytest-forked`` and provides ``--boxed`` as a backward compatibility option.
@@ -14,19 +14,19 @@ to run each test in a controlled subprocess. Here is a basic example:: | |||
@pytest.mark.parametrize("arg", range(50)) | |||
def test_func(arg): | |||
time.sleep(0.05) # each tests takes a while | |||
if arg % 19 == 0: | |||
if arg % 19 == 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add to the top of this file:
.. note::
Since 2.0, the actual implementation of the ``--boxed`` option has been moved to a
separate plugin, `pytest-forked <https://github.com/pytest-dev/pytest-forked>`_
which can be installed independently. The ``--boxed`` command-line options remains
for backward compatibility reasons.
So this will be |
actually, since its compatibly perhaps not , for a real 2.0 i'd also like to remove looponfail |
Oh right. |
Flakes failed on Windows, could you take a look @RonnyPfannschmidt ? |
pytest-xdist 1.19.1 (2017-08-10) ================================ Bug Fixes --------- - Fix crash when transferring internal pytest warnings from workers to the master node. (`#214 <https://github.com/pytest-dev/pytest- xdist/issues/214>`_) pytest-xdist 1.19.0 (2017-08-09) ================================ Deprecations and Removals ------------------------- - ``--boxed`` functionality has been moved to a separate plugin, `pytest-forked <https://github.com/pytest-dev/pytest-forked>`_. This release now depends on `` pytest-forked`` and provides ``--boxed`` as a backward compatibility option. (`#1 <https://github.com/pytest-dev/pytest-xdist/issues/1>`_) Features -------- - New ``--dist=loadscope`` option: sends group of related tests to the same worker. Tests are grouped by module for test functions and by class for test methods. See ``README.rst`` for more information. (`#191 <https://github.com /pytest-dev/pytest-xdist/issues/191>`_) - Warnings are now properly transferred from workers to the master node. (`#92 <https://github.com/pytest-dev/pytest-xdist/issues/92>`_) Bug Fixes --------- - Fix serialization of native tracebacks (``--tb=native``). (`#196 <https://github.com/pytest-dev/pytest-xdist/issues/196>`_)
this will eventually completely remove boxed from the plugin