Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 #259

Merged
merged 7 commits into from
Dec 22, 2017
Merged

Drop support for EOL Python 2.6 #259

merged 7 commits into from
Dec 22, 2017

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Dec 21, 2017

Pytest and Py have both dropped Python 2.6 as it's been EOL for 4 years.

Also remove some redundant Python 3.2 code (also EOL and looks like it's already dropped), some minor code cleanup, and add a Python version badge.


Here's a quick checklist that should be present in PRs:

  • Make sure to include reasonable tests for your change if necessary

  • We use towncrier for changelog management, so please add a news file into the changelog folder following these guidelines:

    • Name it $issue_id.$type for example 588.bugfix;

    • If you don't have an issue_id change it to the PR id after creating it

    • Ensure type is one of removal, feature, bugfix, vendor, doc or trivial

    • Make sure to use full sentences with correct case and punctuation, for example:

      Fix issue with non-ascii contents in doctest text files.
      

Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done, thanks 👍

@jurko-gospodnetic
Copy link

something broken in our bleeding edge code? related tests seem to be failing...

@hugovk
Copy link
Member Author

hugovk commented Dec 21, 2017

Yep the pytestmaster and pytestfeatures build jobs are also failing on latest master:

https://travis-ci.org/hugovk/pytest-xdist/builds/319594409

@nicoddemus
Copy link
Member

I suspect this is breaking because the output has changed and now includes the progress indicator in pytest-3.3, so the code which parses the output is not detecting what it intends to.

@hugovk
Copy link
Member Author

hugovk commented Dec 22, 2017

Thanks, I've created #260 for that, as it's unrelated to this PR.

@nicoddemus
Copy link
Member

Thanks @hugovk. I'm merging this then, and open a PR shortly for #260.

@nicoddemus nicoddemus merged commit ed9f25a into pytest-dev:master Dec 22, 2017
@hugovk hugovk deleted the rm-eol branch December 22, 2017 17:28
@nicoddemus
Copy link
Member

@hugovk 1.21.0 has been released, thanks again for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants