Ensure the docstring is a string

[tushar-deepsource]

Resolves #11140

[RonnyPfannschmidt]

Thanks, I'm under the impression this regression came out of the new expressions handling and we can simplify this once python 3.7 support is dropped

[The-Compiler]

Thanks, I'm under the impression this regression came out of the new expressions handling

That part is correct - with 9335a0b, we now do astStr = ast.Constant, so this catches any constant rather than just strings.

and we can simplify this once python 3.7 support is dropped

That part is not, I believe - the only thing that changes is that we don't have ast.Str anymore, only ast.Constant - thus we still need to have this check.

Thanks @tushar-deepsource! ✨

[The-Compiler]

Thanks for the fix! It'd be great if you could do those:

• Create a new changelog file in the changelog folder, with a name like <ISSUE NUMBER>.<TYPE>.rst. See changelog/README.rst for details.

  Write sentences in the past or present tense, examples:

  • Improved verbose diff output with sequences.
  • Terminal summary statistics now use multiple colors.

  Also make sure to end the sentence with a ..

• Add yourself to AUTHORS in alphabetical order.

I also think we should backport this to 7.4 once merged.

[bluetech]

Yep this was definitely an oversight in 9335a0b.

Along with this change we should also audit the other changes in that commit, but I can do it separately.

Comments addressed

[bluetech]

Along with this change we should also audit the other changes in that commit, but I can do it separately.

Did this, I think this one was the only problematic case.