Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make deleting a bookmark a context menu command #1197

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shtlrs
Copy link
Member

@shtlrs shtlrs commented Jan 29, 2023

Closes #1196

The change is pretty similar to the bookmark one, and makes it more intuitive to delete a book mark straight from the DMs using a context menu command

@ChrisLovering
Copy link
Member

This might be better served with another application command, similar to how we changed the main bookmark command to one.

We can also deprecate the existing text command that way too.

If we make this delete command a global command, we can remove perms for people to run it in-server so it will only appear in DMs.

@shtlrs
Copy link
Member Author

shtlrs commented Feb 21, 2023

we can remove perms for people to run it in-server so it will only appear in DMs.

Humm I see, just like the perms issue that happened for some people with the new bookmark command? That's a good idea.

@ChrisLovering
Copy link
Member

we can remove perms for people to run it in-server so it will only appear in DMs.

Humm I see, just like the perms issue that happened for some people with the new bookmark command? That's a good idea.

At a per command level you can control what users have permission to run it
image

@shtlrs
Copy link
Member Author

shtlrs commented Feb 21, 2023

That's neat.

Alright, sounds pretty good!

@ChrisLovering
Copy link
Member

ChrisLovering commented Feb 21, 2023

That's neat.

Alright, sounds pretty good!

You can set it in-app using this

Setting an empty permissions field will disallow anyone except server administrators from using the command in a guild.

We'd likely still want a check to make sure a user isn't deleting a message in-guild though, just to be sure.

@shtlrs shtlrs marked this pull request as ready for review February 22, 2023 09:20
bot/exts/utilities/bookmark.py Outdated Show resolved Hide resolved
bot/exts/utilities/bookmark.py Outdated Show resolved Hide resolved
bot/exts/utilities/bookmark.py Outdated Show resolved Hide resolved
@Xithrius Xithrius added area: backend Related to internal functionality and utilities area: frontend Related to output and formatting status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features category: utilities Related to utilities labels Mar 3, 2023
@shtlrs shtlrs changed the title Add possibility of deleting a bm with a button Make deleting a bookmark a context menu command Mar 7, 2023
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a singular comment. Besides that, original functionality is in place, very nice.

bot/exts/utilities/bookmark.py Outdated Show resolved Hide resolved
@Xithrius Xithrius added status: waiting for author Waiting for author to address a review or respond to a comment and removed status: needs review Author is waiting for someone to review and approve labels Jan 30, 2024
@shtlrs shtlrs requested review from Xithrius and ChrisLovering and removed request for ChrisLovering and wookie184 March 20, 2024 23:17
@Xithrius Xithrius added status: needs review Author is waiting for someone to review and approve and removed status: waiting for author Waiting for author to address a review or respond to a comment labels May 11, 2024
Copy link
Member

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yuh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: backend Related to internal functionality and utilities area: frontend Related to output and formatting category: utilities Related to utilities status: needs review Author is waiting for someone to review and approve type: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deleting bookmarks
3 participants