-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make deleting a bookmark a context menu command #1197
base: main
Are you sure you want to change the base?
Conversation
This might be better served with another application command, similar to how we changed the main bookmark command to one. We can also deprecate the existing text command that way too. If we make this delete command a global command, we can remove perms for people to run it in-server so it will only appear in DMs. |
Humm I see, just like the perms issue that happened for some people with the new bookmark command? That's a good idea. |
That's neat. Alright, sounds pretty good! |
You can set it in-app using this
We'd likely still want a check to make sure a user isn't deleting a message in-guild though, just to be sure. |
bdc0a29
to
d2f9bc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a singular comment. Besides that, original functionality is in place, very nice.
a6fe30a
to
ff711e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yuh
Closes #1196
The change is pretty similar to the bookmark one, and makes it more intuitive to delete a book mark straight from the DMs using a context menu command