Change method .love command uses to derive score

[jonathan-d-zhang]

Description

Rather than using the usernames, the command should first try nicknames, then fall back to usernames if necessary. Alternatively, according to Nicky, "Love is deep. Love is about the true you". The .love command will use the id of the user rather than the nickname.

Reasoning

This would allow users to change their nicknames in order to get a score of 100% compatibility.

Proposed Implementation

Change https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/holidays/valentines/lovecalculator.py#L62 to be

return clean_content(escape_markdown=True).convert(ctx, arg.nickname or str(arg))

or in the second case

return clean_content(escape_markdown=True).convert(ctx, arg.id)

Would you like to implement this yourself?

• I'd like to implement this feature myself
• Anyone can implement this feature

[wookie184]

I don't really mind, maybe the current behaviour of using usernames is the best balance between letting/not letting people influence the results