Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go through sentry 2.0 migration guide #1530

Open
wookie184 opened this issue May 13, 2024 · 1 comment
Open

Go through sentry 2.0 migration guide #1530

wookie184 opened this issue May 13, 2024 · 1 comment

Comments

@wookie184
Copy link
Contributor

wookie184 commented May 13, 2024

We should make sure we aren't using any of the methods deprecated in this major release, in the migration guide (https://docs.sentry.io/platforms/python/migration/1.x-to-2.x) push_scope is mentioned as being deprecated but we still use it here:

from sentry_sdk import push_scope

Originally posted by @wookie184 in #1519 (comment)

@jb3
Copy link
Member

jb3 commented May 18, 2024

If it helps at all, the only change required for this is to literally swap push_scope for new_scope:

python-discord/bot@5b209b1 (#3047)

Our usages of push_scope are innocuous enough that the slight changes in behaviour are null for us.

@wookie184 wookie184 assigned wookie184 and unassigned wookie184 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants