Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle whitespaces for PEP-440 constraints #16

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

abn
Copy link
Member

@abn abn commented Apr 6, 2020

  • fix incorrect parsing of spaces when parsing version constraints
  • add tests for parse_constraint

This issue was discovered while installing vendoring package. This package uses ~= 3.8.0 for its python version requirement, which was failing due to the whitespace.

$ poetry add -D vendoring
Using version ^0.2.2 for vendoring

Updating dependencies
Resolving dependencies... (0.0s)

[ValueError]
Could not parse version constraint: ~= 3.8.0

* fix incorrect parsing of spaces when parsing version constraints
* add tests for `parse_constraint`
Copy link
Member

@kasteph kasteph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- LGTM 💫

@abn abn merged commit 1172536 into python-poetry:master Apr 8, 2020
@abn abn deleted the fix-parse-constraint branch April 8, 2020 18:28
@sdispater sdispater mentioned this pull request Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants