From 2d2ee7ef905baff476f755d3e8a8511e72586779 Mon Sep 17 00:00:00 2001 From: Bart Kamphorst Date: Fri, 30 Sep 2022 23:26:39 +0200 Subject: [PATCH] refactor: Pool should not inherit from Repository --- src/poetry/repositories/pool.py | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/poetry/repositories/pool.py b/src/poetry/repositories/pool.py index 43f1e9d2a06..3dfacd66b9e 100644 --- a/src/poetry/repositories/pool.py +++ b/src/poetry/repositories/pool.py @@ -3,7 +3,6 @@ from typing import TYPE_CHECKING from poetry.repositories.exceptions import PackageNotFound -from poetry.repositories.repository import Repository if TYPE_CHECKING: @@ -11,14 +10,16 @@ from poetry.core.packages.dependency import Dependency from poetry.core.packages.package import Package + from poetry.repositories.repository import Repository -class Pool(Repository): + +class Pool: def __init__( self, repositories: list[Repository] | None = None, ignore_repository_names: bool = False, ) -> None: - super().__init__("poetry-pool") + self._name = "poetry-pool" if repositories is None: repositories = [] @@ -34,6 +35,10 @@ def __init__( self._ignore_repository_names = ignore_repository_names + @property + def name(self) -> str: + return self._name + @property def repositories(self) -> list[Repository]: return self._repositories @@ -128,9 +133,6 @@ def remove_repository(self, repository_name: str) -> Pool: return self - def has_package(self, package: Package) -> bool: - raise NotImplementedError() - def package( self, name: str,