Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep old line breaking in toml files #2993

Closed
2 tasks done
trim21 opened this issue Sep 28, 2020 · 6 comments
Closed
2 tasks done

keep old line breaking in toml files #2993

trim21 opened this issue Sep 28, 2020 · 6 comments
Labels
kind/feature Feature requests/implementations

Comments

@trim21
Copy link
Contributor

trim21 commented Sep 28, 2020

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Feature Request

I keep pyproject.toml and lock file in my code repo with \n as eol. but poetry will always make it crlf on Windows, it's pretty annoying.

create a pr in python-poetry/tomlkit#110

@trim21 trim21 added kind/feature Feature requests/implementations status/triage This issue needs to be triaged labels Sep 28, 2020
@trim21 trim21 changed the title keep old line breaking on toml files keep old line breaking oin toml files Sep 28, 2020
@trim21 trim21 changed the title keep old line breaking oin toml files keep old line breaking in toml files Sep 28, 2020
@abn
Copy link
Member

abn commented Sep 28, 2020

@trim21 happy to see a PR to preserve line endings. But I suspect change might be in tomlkit.

@trim21
Copy link
Contributor Author

trim21 commented Sep 29, 2020

@abn I'm not sure if tomlkit should take care of line breaking... 🤔

@finswimmer
Copy link
Member

Should be fixed by tomlkit.

@mkniewallner mkniewallner removed the status/triage This issue needs to be triaged label Jun 11, 2022
@trim21
Copy link
Contributor Author

trim21 commented Sep 1, 2023

this is broken again,, can we re-open this issue?

❯❯ ~\..\..\poetry-plugin-bump git:(master) poetry --version
Poetry (version 1.6.1)
❯❯ ~\..\..\poetry-plugin-bump git:(master) file poetry.lock
poetry.lock: ASCII text
❯❯ ~\..\..\poetry-plugin-bump git:(master) poetry lock
Updating dependencies
Resolving dependencies...

Writing lock file
❯❯ ~\..\..\poetry-plugin-bump git:(master) file poetry.lock
poetry.lock: ASCII text, with CRLF line terminators

@dimbleby
Copy link
Contributor

dimbleby commented Sep 1, 2023

No. #7527.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Feature requests/implementations
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants