Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poetry env remove - exit code 1 #3617

Closed
2 tasks done
steveYeah opened this issue Jan 29, 2021 · 2 comments
Closed
2 tasks done

poetry env remove - exit code 1 #3617

steveYeah opened this issue Jan 29, 2021 · 2 comments

Comments

@steveYeah
Copy link

steveYeah commented Jan 29, 2021

  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have searched the documentation and believe that my question is not covered.

Issue

By raising an exception in EnvManager::Remove when the venv does not exist, poetry will error out, showing the exception.

It would be nicer for scripting the use of Poetry in Makefiles and the like, if poetry env remove <venv> just no-oped when venv did not exist, as it's no real drama if the thing you want to delete doesn't exist.

I use this as part of a clean target within a project Makefile, and as this raises an exception, it will exist with status code 1, meaning the rest of the target is not executed

Many thanks!
@steveYeah

@steveYeah
Copy link
Author

This PR will solve this issue #3212 (review).

Copy link

github-actions bot commented Mar 1, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants