poetry update --lock prints operations that don't run.

[hwmq]

• Poetry version: 1.4.0

• Python version: 3.10.6

• OS version and name: Ubuntu 22.04

• pyproject.toml: N/A

• I am on the latest stable Poetry version, installed using a recommended method.

• I have searched the issues of this repo and believe that this is not a duplicate.

• I have consulted the FAQ and blog for any relevant entries or release notes.

• If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

poetry update --lock prints operations that don't run. The following gives the gist...

$ poetry update --lock mypackage
Updating dependencies
Resolving dependencies... (0.9s)

Writing lock file
  • Installing a_different_package (0.0.0): Pending...
  • Updating some_other_package (0.0.0 -> 1.0.0): Pending...
# ... and so on ...
$ # and back to my shell.

To be clear, some_other_package is not updated in the lock file.

Essentially, the printed operations correspond to what would happen in the poetry env if --lock were not specified. However since --lock is specified, it doesn't make sense to show this output, because these things do not happen.

We can see this here (tag 1.4.0)

poetry/src/poetry/console/commands/update.py

Line 54 in 0e72a55

self.installer.execute_operations(not self.option("lock"))

Poetry actually ends up reaching this line, which doesn't end up doing anything because self._execute_operations is False, but does print the output like above.

poetry/src/poetry/installation/executor.py

Line 187 in 0e72a55

tasks.append(self._executor.submit(self._execute_operation, operation))

I wonder if when --lock is specified, should we also call self.installer.lock()? That way, the return in this block will execute. Currently it does not because self._lock is False

poetry/src/poetry/installation/installer.py

Lines 294 to 299 in 0e72a55

	if self._update:
	self._write_lock_file(lockfile_repo)
	if self._lock:
	# If we are only in lock mode, no need to go any further
	return 0

add already does this.

poetry/src/poetry/console/commands/add.py

Lines 257 to 258 in 0e72a55

	if self.option("lock"):
	self.installer.lock()

[hwmq]

Proposed fix. edit: this causes poetry update --lock to have the same bug as poetry add --lock (see #7309)

diff --git a/src/poetry/console/commands/update.py b/src/poetry/console/commands/update.py
index 955438a5..a6521a81 100644
--- a/src/poetry/console/commands/update.py
+++ b/src/poetry/console/commands/update.py
@@ -51,7 +51,11 @@ class UpdateCommand(InstallerCommand):
 
         self.installer.only_groups(self.activated_groups)
         self.installer.dry_run(self.option("dry-run"))
-        self.installer.execute_operations(not self.option("lock"))
+
+        if self.option("lock"):
+            self.installer.lock()
+        else:
+            self.installer.execute_operations()
 
         # Force update
         self.installer.update(True)

Results of poetry run pytest are the same with and without this patch.

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.