Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible API breakers in ParkingLot #53

Open
njsmith opened this issue Feb 13, 2017 · 1 comment
Open

Possible API breakers in ParkingLot #53

njsmith opened this issue Feb 13, 2017 · 1 comment

Comments

@njsmith
Copy link
Member

njsmith commented Feb 13, 2017

See the big comment at the top of the file.

In particular:

  • We might want to switch to a single global ParkingLot, in which case the API would shift quite a bit. (Instead of having ParkingLot objects, we'd have an argument which was an arbitrary id naming the synchronization object.)

  • If we implement WFQ (Design: alternative scheduling models #32) then we'd probably need to stop returning the unparked tasks from unpark. (This would slightly complicate the implementation of RLock and Condition, but I don't think it's too bad.)

  • We might want to add a way for tasks to mark themselves when parking, but probably this could be done in a backwards compatible way.

@njsmith
Copy link
Member Author

njsmith commented Feb 13, 2017

I also wonder if we might want to remove the result= argument to unpark? I don't think anything actually uses it, and it also might complicate any scheduling experiments...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant