You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To modify configure.ac, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.
Probably, we should teach Bedevere to call this image for us, save the generated configure as a workflow artifact and post a link with an explanatory note on what it's for and how to use it.
To modify configure.ac, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.
I am not sure for this suggestion.
If user didn't regenerate configure file, how do we can belive that user verify the change in their local environment?
Fortunately, Check if generated files are up to datealready prints a diff that perfectly solves the underlying issue without adding anything to Bedevere:
iftest -n "$changes";thenecho"Generated files not up to date."echo"Perhaps you forgot to run make regen-all or build.bat --regen. ;)"echo"configure files must be regenerated with a specific version of autoconf."echo"$changes"echo""
git diff --staged ||trueexit 1
fi
To modify
configure.ac
, contributors need to use the https://github.com/tiran/cpython_autoconf Docker image. However, Windows users are out of luck; for my contributions I need to use a throwaway GitHub Actions workflow.Probably, we should teach Bedevere to call this image for us, save the generated
configure
as a workflow artifact and post a link with an explanatory note on what it's for and how to use it.I propose to implement it as a GitHub action (with a Python link poster) because it already supports custom Docker images. Also, it would be the first step towards gh-344.
The text was updated successfully, but these errors were encountered: