Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45141: allow specifying files for mailcap.getcaps #28245

Closed
wants to merge 1 commit into from

Conversation

pacien
Copy link

@pacien pacien commented Sep 8, 2021

This allows the caller of the function to specify a list of files to
parse and get the MIME mapping from. The added parameter is optional and
the previous behaviour is preserved otherwise.

https://bugs.python.org/issue45141

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@pacien

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

This allows the caller of the function to specify a list of files to
parse and get the MIME mapping from. The added parameter is optional and
the previous behaviour is preserved otherwise.
@pacien pacien force-pushed the bpo-45141-mailcap-files-param branch from 44d1cf5 to 25a12c6 Compare September 10, 2021 14:36
@pacien pacien changed the title bpo-45141: allow specifying files for mailcap.getcaps() bpo-45141: allow specifying files for mailcap.getcaps Sep 10, 2021
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 11, 2021
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran 8 tests in 0.023s

OK

== Tests result: SUCCESS ==

@hugovk
Copy link
Member

hugovk commented Apr 26, 2022

Note that mailcap will be deprecated in Python 3.11 and removed in 3.13:

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 12, 2022
@furkanonder
Copy link
Contributor

furkanonder commented May 9, 2023

Note that mailcap will be deprecated in Python 3.11 and removed in 3.13:

* [PEP 594 – Removing dead batteries from the standard library](https://peps.python.org/pep-0594/)

* [Deprecate modules listed in PEP 594 #91217](https://github.com/python/cpython/issues/91217)

Now that the module has been deprecated and the related issue has been closed. I think we can close the PR.

@arhadthedev
Copy link
Member

I agree. Closing because 3.12 (the last version with mailcap) no longer accepts new features.

@arhadthedev arhadthedev closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants