From 97f60f5e9c4ef79f9aa1358c01b0c04047e03be1 Mon Sep 17 00:00:00 2001 From: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Date: Sun, 12 Jun 2022 15:16:09 +0000 Subject: [PATCH 1/2] use static strings --- Objects/typeobject.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Objects/typeobject.c b/Objects/typeobject.c index e57651446f888f..349192800b882c 100644 --- a/Objects/typeobject.c +++ b/Objects/typeobject.c @@ -3637,13 +3637,13 @@ PyType_FromMetaclass(PyTypeObject *metaclass, PyObject *module, if (weaklistoffset) { type->tp_weaklistoffset = weaklistoffset; - if (PyDict_DelItemString((PyObject *)type->tp_dict, "__weaklistoffset__") < 0) { + if (PyDict_DelItem((PyObject *)type->tp_dict, &_Py_ID(__weaklistoffset__)) < 0) { goto finally; } } if (dictoffset) { type->tp_dictoffset = dictoffset; - if (PyDict_DelItemString((PyObject *)type->tp_dict, "__dictoffset__") < 0) { + if (PyDict_DelItem((PyObject *)type->tp_dict, &_Py_ID(__dictoffset__)) < 0) { goto finally; } } From d4e9e9aac583d977eb3ab233006d984b4dff35d0 Mon Sep 17 00:00:00 2001 From: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com> Date: Sun, 12 Jun 2022 15:17:41 +0000 Subject: [PATCH 2/2] regen --- Include/internal/pycore_global_strings.h | 2 ++ Include/internal/pycore_runtime_init.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Include/internal/pycore_global_strings.h b/Include/internal/pycore_global_strings.h index ca970627cb2e17..af6c5ebaaf9def 100644 --- a/Include/internal/pycore_global_strings.h +++ b/Include/internal/pycore_global_strings.h @@ -90,6 +90,7 @@ struct _Py_global_strings { STRUCT_FOR_ID(__delete__) STRUCT_FOR_ID(__delitem__) STRUCT_FOR_ID(__dict__) + STRUCT_FOR_ID(__dictoffset__) STRUCT_FOR_ID(__dir__) STRUCT_FOR_ID(__divmod__) STRUCT_FOR_ID(__doc__) @@ -206,6 +207,7 @@ struct _Py_global_strings { STRUCT_FOR_ID(__typing_subst__) STRUCT_FOR_ID(__typing_unpacked_tuple_args__) STRUCT_FOR_ID(__warningregistry__) + STRUCT_FOR_ID(__weaklistoffset__) STRUCT_FOR_ID(__weakref__) STRUCT_FOR_ID(__xor__) STRUCT_FOR_ID(_abc_impl) diff --git a/Include/internal/pycore_runtime_init.h b/Include/internal/pycore_runtime_init.h index 5e57ac68776c8a..2420d81a8a238a 100644 --- a/Include/internal/pycore_runtime_init.h +++ b/Include/internal/pycore_runtime_init.h @@ -712,6 +712,7 @@ extern "C" { INIT_ID(__delete__), \ INIT_ID(__delitem__), \ INIT_ID(__dict__), \ + INIT_ID(__dictoffset__), \ INIT_ID(__dir__), \ INIT_ID(__divmod__), \ INIT_ID(__doc__), \ @@ -828,6 +829,7 @@ extern "C" { INIT_ID(__typing_subst__), \ INIT_ID(__typing_unpacked_tuple_args__), \ INIT_ID(__warningregistry__), \ + INIT_ID(__weaklistoffset__), \ INIT_ID(__weakref__), \ INIT_ID(__xor__), \ INIT_ID(_abc_impl), \