Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.950 planning #12579

Closed
JukkaL opened this issue Apr 13, 2022 · 27 comments
Closed

Release 0.950 planning #12579

JukkaL opened this issue Apr 13, 2022 · 27 comments
Labels
meta Issues tracking a broad area of work

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Apr 13, 2022

I'm planning to make a 0.950 release by Apr 22 (tentative timeline).

Please post here any issues you'd like to see fixed in the release, or PRs you'd like to have merged. I've already cut the release branch, but we can still cherry-pick low-risk features and bug fixes until Apr 18. After Apr 18 only critical bug fixes and documentation updates should be cherry-picked.

@JukkaL JukkaL added the meta Issues tracking a broad area of work label Apr 13, 2022
@AlexWaygood
Copy link
Member

For typeshed, there's a trio of PEP-604 type-alias bugs which it would be great to see fixed, if at all possible:

(There are a few others as well, but these are the ones which are a blocker for typeshed to use PEP-604 syntax everywhere.)

@cdce8p
Copy link
Collaborator

cdce8p commented Apr 13, 2022

@97littleleaf11
Copy link
Collaborator

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 14, 2022

This regression seems pretty serious, and I'm trying to prepare a fix in time for the release:

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 14, 2022

This is blocking some typeshed improvements:

@huguesb
Copy link
Contributor

huguesb commented Apr 14, 2022

#12032

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Apr 16, 2022

I missed the branch cut date. Thoughts on cherry picking an additional typeshed sync #12596 ? Should be pretty low risk (relatively few changes, no mypy-primer utput, includes assert_type, better ExceptionGroup support)

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 17, 2022

This was merged, would appreciate cherry-picking it into the release branch.

Edit: please also cherry-pick #12612

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 17, 2022

#12610 is claimed to be a regression since 0.942, so we should fix it before the release.

@AlexWaygood
Copy link
Member

AlexWaygood commented Apr 17, 2022

@huguesb mentioned this one above — I haven't looked at it in depth, but it looks like it might help with the enum-related performance regressions you've recently been working on @JukkaL

@huguesb
Copy link
Contributor

huguesb commented Apr 18, 2022

* [FindModuleCache: leverage BuildSourceSet #9478](https://github.com/python/mypy/pull/9478)

I apologize for the inconvenience. I accidentally deleted the underlying branch which closed #9478
Re-opened as #12616 after rebasing on master.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 19, 2022

Cherry-picked these PRs:

This has also been fixed:

If the latter doesn't cause issues I can, cherry-pick the assert_type PR afterwards.

I've been investigating a few other potential regressions (no GitHub issues yes) so I'm a little behind. I can still merge new features until tomorrow. Bug fixes can be merged afterwards.

@cdce8p
Copy link
Collaborator

cdce8p commented Apr 19, 2022

I can still merge new features until tomorrow.

If still possible, it would be awesome if this one could be included.

@huguesb
Copy link
Contributor

huguesb commented Apr 20, 2022

@JukkaL I believe your recent changes to make_simplified_union actually caused performance regressions. I have a proposed solution, with clarifying comments in #12630

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 20, 2022

Cherry-picked assert_type PRs:

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 20, 2022

Cherry-picked enum/union optimizations:

@huguesb
Copy link
Contributor

huguesb commented Apr 20, 2022

Speeding up error-counting: #12631

@hauntsaninja
Copy link
Collaborator

Regression from the change to namespace typevars: #12633

@huguesb
Copy link
Contributor

huguesb commented Apr 22, 2022

Per-file timing stats #12639

@cdce8p
Copy link
Collaborator

cdce8p commented Apr 24, 2022

#12668 is an awesome PR which addresses some outstanding issues with P.args and P.kwargs.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 25, 2022

I'm a little behind schedule, since there were a few tricky regressions that I'm still working on. Only fixes to regressions and low-risk fixes to (significant) bugs can be merged until the release (+ doc updates).

It may be okay to include #12668, but no promises.

@JukkaL
Copy link
Collaborator Author

JukkaL commented Apr 27, 2022

Mypy 0.950 is out: http://mypy-lang.blogspot.com/2022/04/mypy-0950-released.html

Some PRs were left out, unfortunately, but we'll probably have a bugfix release in 1-2 weeks (or earlier if there is a major regression) which can include fixes to regressions and low-risk bug fixes. Feel free to suggest PRs to include in a bugfix release here.

The next feature release will likely go out in the second half of May or early June.

@hauntsaninja
Copy link
Collaborator

hauntsaninja commented Apr 28, 2022

#12685 is a crash that bisects to #12656 (Fix types of inherited attributes in generic dataclasses).
Edit: now has a minimal repro

@cdce8p
Copy link
Collaborator

cdce8p commented Apr 28, 2022

Noticed #12548 wasn't included. It fixed a crash with ParamSpec

@JukkaL
Copy link
Collaborator Author

JukkaL commented May 18, 2022

I'm going to skip the bugfix release, since 0.960 should be out soon.

@JukkaL JukkaL closed this as completed May 18, 2022
@intgr
Copy link
Contributor

intgr commented May 24, 2022

I noticed that the "News" section on the official website http://mypy-lang.org/news.html is missing the 0.950 release (related: #12811)

@JukkaL
Copy link
Collaborator Author

JukkaL commented May 24, 2022

@intgr Oops, I will update the the website when 0.960 goes out (should happen any time now!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues tracking a broad area of work
Projects
None yet
Development

No branches or pull requests

8 participants