Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries can no longer use tool.mypy.python_version = "3.7" #11580

Closed
blink1073 opened this issue Mar 12, 2024 · 2 comments
Closed

Libraries can no longer use tool.mypy.python_version = "3.7" #11580

blink1073 opened this issue Mar 12, 2024 · 2 comments

Comments

@blink1073
Copy link

In PyMongo we still support Python 3.7, and use [tool.mypy.python_version] to specify our min supported typing version.

The effect of #11554 is that we will have to remove this config and run the tests specifically on Python 3.7. That isn't a problem for us, but I wanted to flag it has a possibly unintended side effect.

@srittau
Copy link
Collaborator

srittau commented Mar 12, 2024

typeshed dropped Python 3.7 support a while back. It's most likely not possible to run a type checker using Python 3.7 with current stubs, and potentially Python 3.7 problems won't be flagged when using --python-version 3.7.

I would recommend to pin the versions of the stubs that still support Python 3.7.

@blink1073
Copy link
Author

By running on Python 3.7, we can take advantage of requires-python and avoid manual pins.

@srittau srittau closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants