-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis: Add missing exported names #10151
Conversation
- redis.asyncio.RedisCluster / redis.asyncio.CommandsParser, added in 4.3.0 - redis.default_backoff / redis.asyncio.default_backoff, added in 4.4.0
(Nit: we prefer to avoid force pushes where possible at typeshed, as it makes it hard to see what changed between commits, and doesn't play very well with the GitHub UI. All PRs are squash-merged at typeshed, so there's no need to worry about a clean git history on the PR :) |
This comment has been minimized.
This comment has been minimized.
Ah, I'll keep that in mind! Yes, I normally aim to provide a clean commit series, as a small mistake like forgetting to put |
The failing stubtest is already reported as #9127, and I think now depends on a new release of Redis with redis/redis-py#2729 included? |
Yes, I think it would be fine just to add an allowlist entry for now! |
The original location,`redis.asyncio.cluster.RedisCluster `, is already listed here.
I saw the original |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
redis.asyncio.RedisCluster
/redis.asyncio.CommandsParser
added in 4.3.0redis.default_backoff
/redis.asyncio.default_backoff
, added in 4.4.0