Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python_requires to valid PEP 440 syntax #255

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

jborean93
Copy link
Contributor

As reported in python-poetry/poetry#4201 the existing python_requires valid of >=3.6.* is invalid and should be >=3.6. PEP440 only states that the wildcard suffix is used with version matching ==. The ordered sections do not state it allows the same rules as == unlike the section for != does.

This still seems to work fine with pip luckily but tools like poetry seem to be a bit more strict in the intepretation and the upcoming version will error if they encounter this syntax python-poetry/poetry#4201.

@jborean93 jborean93 changed the title Fix python_requires to valid PEP 345 syntax Fix python_requires to valid PEP 440 syntax Jun 23, 2021
Signed-off-by: Jordan Borean <jborean93@gmail.com>
Copy link
Member

@frozencemetery frozencemetery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree/disagree with that interpretation of PEP440 , but it does state that X.Y.0 is equivalent to X.Y, so this change is fine regardless.

@frozencemetery frozencemetery merged commit baeedbe into pythongssapi:main Jun 23, 2021
@jborean93 jborean93 deleted the python-requires branch June 23, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants