Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing between maximization & minimization with BoTorch acquisition functions #2439

Closed
AdrianSosic opened this issue Jul 22, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@AdrianSosic
Copy link
Contributor

🚀 Feature Request

Hi, I've been running into the same question as already raised in #402. It seems the issue has been simply closed, without actually addressing the problem?

I'd love to understand:

  • Why is the maximize argument only available for some of the acquisition function classes and not simply for all?
  • Regarding the proposed alternative of going via an AcquisitionObjective: has this idea been dropped in the meantime? At least, I can't find anything that offers an easy user-facing functionality to accomplish it 🤔

Of course, I could come up with a manual workaround, e.g. using a posterior transform, but interface-wise I think this defeats the purpose. I'd rather expect that there should be a consistent way to trigger minimization that does not depend on the particular acquisition function class at hand. And having something simple like maximize=False that does not require setting up other objects seems like the ideal solution to me.

@AdrianSosic AdrianSosic added the enhancement New feature or request label Jul 22, 2024
@saitcakmak
Copy link
Contributor

Hi @AdrianSosic. The current acquisition functions that support this argument support it for legacy reasons. We do not believe adding maximize option to other acquisition functions justifies the maintenance work it requires. Please refer to my answer in #2316 for current options for minimization in BoTorch.

@saitcakmak saitcakmak changed the title [Feature Request] Acqf minimization Choosing between maximization & minimization with BoTorch acquisition functions Jul 22, 2024
@pytorch pytorch locked and limited conversation to collaborators Jul 22, 2024
@saitcakmak saitcakmak converted this issue into discussion #2442 Jul 22, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants