From 3326dc33d075988eefd362b3aae857b01cb4d7a8 Mon Sep 17 00:00:00 2001 From: Jorge Pineda Date: Fri, 8 Mar 2024 10:12:16 -0800 Subject: [PATCH] [ET-VK][EZ] Fix Android test linkage In https://github.com/pytorch/executorch/pull/2305, I added the `soname = "libvulkan_graph_runtime.$(ext)"` to the wrong library. Noob mistake. Also, removed an unneeded dependency. Differential Revision: [D54688153](https://our.internmc.facebook.com/intern/diff/D54688153/) [ghstack-poisoned] --- backends/vulkan/targets.bzl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/backends/vulkan/targets.bzl b/backends/vulkan/targets.bzl index 105ef501fa..76a3bd61ee 100644 --- a/backends/vulkan/targets.bzl +++ b/backends/vulkan/targets.bzl @@ -60,6 +60,8 @@ def define_common_targets(): # therefore link_whole must be True to make sure unused symbols are not discarded. # @lint-ignore BUCKLINT: Avoid `link_whole=True` link_whole = True, + # Define an soname that can be used for dynamic loading in Java, Python, etc. + soname = "libvulkan_graph_runtime.$(ext)", ) runtime.cxx_library( @@ -85,6 +87,4 @@ def define_common_targets(): # VulkanBackend.cpp needs to compile with executor as whole # @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole) link_whole = True, - # Define an soname that can be used for dynamic loading in Java, Python, etc. - soname = "libvulkan_graph_runtime.$(ext)", )