Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a southern hemisphere pass test. #50

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

gerritholl
Copy link
Member

Add a test that passes over the south pole aren't confused with passes
over the north pole. I thought this test would fail, but it actually
passes, so the problem I found with pytroll-collectors adding a granule
to both areas is elsewhere.

There is no corresponding issue yes as I haven't yet found the cause of my problem; either it's a bug in my config or in a pytroll package, but I don't yet know where. Triggered by those log messages from gatherer (in pytroll-collectors):

    [DEBUG: 2021-02-03 17:21:27 : pytroll_collectors.trigger] mda: {'path': '', 'platform_name': 'Metop-B', 'start_time': datetime.datetime(2021, 2, 3, 16, 28, 3), 'end_time': datetime.datetime(2021, 2, 3, 16, 31, 3), 'processing_time': datetime.datetime(2021, 2, 3, 17, 19, 5), 'uri': '/data/pytroll/IN/EMC_AVR/AVHR_xxx_1B_M01_20210203162803Z_20210203163103Z_N_O_20210203171905Z', 'uid': 'AVHR_xxx_1B_M01_20210203162803Z_20210203163103Z_N_O_20210203171905Z', 'sensor': ['avhrr/3'], 'orig_platform_name': 'M01'}
    [DEBUG: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Adding area ID to metadata: eurol
    [INFO: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Added Metop-B (2021-02-03 16:28:03) granule to area eurol
    [DEBUG: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Adding area ID to metadata: nparktis1km
    [INFO: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Added Metop-B (2021-02-03 16:28:03) granule to area nparktis1km
    [DEBUG: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Adding area ID to metadata: spantarktis3km
    [INFO: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Added Metop-B (2021-02-03 16:28:03) granule to area spantarktis3km
    [DEBUG: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Adding area ID to metadata: npgroenland2200m
    [INFO: 2021-02-03 17:21:27 : pytroll_collectors.region_collector] Platform name Metop-B and sensor ['avhrr/3']: Start and end times = 20210203 16:28:03 20210203 16:31:03
  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

gerritholl and others added 3 commits February 4, 2021 17:32
Add a test that passes over the south pole aren't confused with passes
over the north pole.  I thought this test would fail, but it actually
passes, so the problem I found with pytroll-collectors adding a granule
to both areas is elsewhere.
@ghost
Copy link

ghost commented Feb 4, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice with some extra tests!

@mraspaud mraspaud merged commit 8273ee1 into pytroll:master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants