Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mersi-2 as instrument name #61

Merged
merged 4 commits into from
Oct 4, 2021

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Sep 7, 2021

  • Tests added
  • Tests passed
  • Passes git diff origin/master **/*py | flake8 --diff

Pytroll Schedule assumed the instrument name for MERSI-2 to be mersi2, which doesn't work with other parts of the Pytroll ecosystem. This PR makes also mersi-2, which is the instrument name in Satpy, to work.

Closes #59

@pnuu pnuu requested a review from adybbroe September 7, 2021 07:51
@pnuu pnuu self-assigned this Sep 7, 2021
@pnuu pnuu requested review from alexmaul and mraspaud September 7, 2021 10:47
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@bc61c3a). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage        ?   46.49%           
=======================================
  Files           ?       15           
  Lines           ?     2540           
  Branches        ?        0           
=======================================
  Hits            ?     1181           
  Misses          ?     1359           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc61c3a...e7f87fd. Read the comment docs.

@pnuu pnuu mentioned this pull request Oct 2, 2021
4 tasks
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry for the late review.

@mraspaud mraspaud merged commit 51ed121 into pytroll:main Oct 4, 2021
@pnuu pnuu deleted the bugfix-fix-instrument-names branch October 4, 2021 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in Schedule tests
2 participants