Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tiles element from geoviews #3515

Merged
merged 11 commits into from
Feb 22, 2019
Merged

Added Tiles element from geoviews #3515

merged 11 commits into from
Feb 22, 2019

Conversation

philippjfr
Copy link
Member

No description provided.

@philippjfr philippjfr added the type: feature A major new feature label Feb 21, 2019
@philippjfr philippjfr force-pushed the tiles_element branch 2 times, most recently from 9741fbb to d650e4a Compare February 21, 2019 17:07
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@jlstevens
Copy link
Contributor

Looks good.

I didn't know you were working on this so I started working on a PR with the same goal - it looks you beat me to it as I was doing exactly the same thing!

@jlstevens
Copy link
Contributor

Happy to see this merged when the tests pass.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; happy to see it merged!

@jlstevens
Copy link
Contributor

Tests are green before the docstring fixes (except for appveyor which passed on the next commit). Merging.

@jlstevens jlstevens merged commit e3b3d4d into master Feb 22, 2019
@philippjfr philippjfr deleted the tiles_element branch April 29, 2019 11:24
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature A major new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants