Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with np.clip #138

Closed
pzivich opened this issue Jun 30, 2020 · 1 comment
Closed

Replace with np.clip #138

pzivich opened this issue Jun 30, 2020 · 1 comment
Assignees
Labels
Causal inference Updates for the causal inference branch enhancement

Comments

@pzivich
Copy link
Owner

pzivich commented Jun 30, 2020

def _bounding_(v, bounds):

Replace the treatment probability bounding with np.clip since that is easier to keep up with overall

Same needs to be done for TMLE with the continuous outcome bounding

@pzivich pzivich added enhancement Causal inference Updates for the causal inference branch labels Jun 30, 2020
@pzivich pzivich self-assigned this Jun 30, 2020
@pzivich pzivich mentioned this issue Jul 12, 2020
17 tasks
@pzivich
Copy link
Owner Author

pzivich commented Dec 15, 2020

I don't need to replace with np.clip. I have another filtering approach that doesn't rely on any function (but also doesn't produce warnings). Implementation is in #151

@pzivich pzivich closed this as completed Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Causal inference Updates for the causal inference branch enhancement
Projects
None yet
Development

No branches or pull requests

1 participant