Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder Toolbar and add Guess Column Properties #135

Closed
Stephen-Gates opened this issue Oct 4, 2017 · 4 comments
Closed

Reorder Toolbar and add Guess Column Properties #135

Stephen-Gates opened this issue Oct 4, 2017 · 4 comments
Labels
f:Feature-request This issue is a request for a new feature fn:Interface priority:Medium
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Stephen-Gates commented Oct 4, 2017

Desired Behaviour

A tester reports, "the validate icon appears first, but should really be executed after the column and table properties are set".

image

See also #134 for a suggestion to add Guess Column Properties to the toolbar.

Question

What should appear on the Toolbar and in what order?

One workflow could be:

  1. open csv
  2. guess column properties
  3. set column properties
  4. set table properties
  5. validate
  6. set provenance information
  7. set data package properties
  8. export

Another workflow could be:

  1. open csv
  2. validate (without a schema)
  3. edit data to resolve "structural" errors (blank rows, duplicate headers, etc)
  4. validate
  5. guess column properties
  6. set column properties
  7. validate (with a schema)
  8. set table properties
  9. validate (with a schema and foreign keys and missing values)
  10. set provenance information
  11. set data package properties
  12. export

Proposal

Toolbar icons in the following order:

  1. guess column properties (icon to be determined)
  2. set column properties
  3. set table properties
  4. set provenance information
  5. set data package properties
  6. validate (in this position to avoid breaking flow between panels using next/previous arrows)
  7. export

screenshot 2017-10-04 21 51 46

@Stephen-Gates Stephen-Gates added f:Feature-request This issue is a request for a new feature f:Question A question for project maintainers and contributors labels Oct 4, 2017
@Stephen-Gates Stephen-Gates added this to the v0.4.0 milestone Oct 4, 2017
@Stephen-Gates
Copy link
Contributor Author

Tester 2 suggests, "the validate button should be the penultimate button (the button immediately before the 'Export')".

@Stephen-Gates
Copy link
Contributor Author

Added 1515562 in anticipation of a change

@Stephen-Gates
Copy link
Contributor Author

If proposal above is OK, then I've made a start on implementing #138

@Stephen-Gates
Copy link
Contributor Author

After discussions, going with...

screenshot 2017-10-04 21 51 46

@Stephen-Gates Stephen-Gates added priority:Medium and removed f:Question A question for project maintainers and contributors labels Oct 11, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.4.0, v0.5.0 Oct 25, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.5.0, v0.7.0 Nov 8, 2017
@Stephen-Gates Stephen-Gates changed the title What should appear on the Toolbar and in what order? Reorder Toolbar and add Guess Column Properties Nov 8, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.7.0, v0.6.0 Nov 16, 2017
@ghost ghost closed this as completed in de37ef3 Nov 29, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:Feature-request This issue is a request for a new feature fn:Interface priority:Medium
Projects
None yet
Development

No branches or pull requests

1 participant