Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Side and Bottom panel should push (not cover) main content #317

Closed
Stephen-Gates opened this issue Dec 12, 2017 · 6 comments
Closed

Side and Bottom panel should push (not cover) main content #317

Stephen-Gates opened this issue Dec 12, 2017 · 6 comments
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Major Major effort to implement f:Feature-request This issue is a request for a new feature fn:Interface priority:Medium
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Desired Behaviour (for feature requests only)

Side and Bottom panels should push and resize main content rather than cover it. This way the table scroll bars remain accessible.

Current Behaviour (for problems)

Scroll bars are covered when panels are open

image

Your Environment

  • Data Curator version: 0.7.0
  • Operating System and version: e.g. Windows & MacOS
@Stephen-Gates Stephen-Gates added env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows f:Feature-request This issue is a request for a new feature fn:Interface labels Dec 12, 2017
@Stephen-Gates Stephen-Gates added this to the v1.x.x milestone Dec 12, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@ghost ghost added the est:Minor Minor effort to implement label Jan 10, 2018
@ghost
Copy link

ghost commented Jan 10, 2018

@Stephen-Gates, From the title, it suggests that this is also happening with side panels - which some code was added for - is this a bug in the side panels?
From the example, it looks like you want this enhancement for the bottom panel (where it hasn't existed) - so yes can change this.

@Stephen-Gates
Copy link
Contributor Author

Stephen-Gates commented Jan 10, 2018

Thanks Matt I’ll test the side panels again to make sure they’re working. I recall different behaviour depending on the width of the data

@Stephen-Gates
Copy link
Contributor Author

  1. Create a new data tab
  2. Add columns beyond width of screen -> scroll bar appears ✔️
  3. Add rows beyond the height of the screen -> -> scroll bar appears ✔️
  4. Select Column from toolbar -> side panel opens, vertical scroll bar disappears 😢
  5. Select Validate from toolbar -> bottom panel opens, all scroll bars disappears 😭
  6. Close bottom panel -> horizontal scroll bar no longer covered 😄
  7. Close side panel -> vertical scroll bar no longer covered 😄
  8. Open side panel
  9. Resize window
  10. Close side panel -> table not resized

image

@ghost
Copy link

ghost commented Jan 11, 2018

Thanks @Stephen-Gates
Nice icons :)
There is a bit of an issue with re-rendering - not sure if it's within our stuff or hot yet.
For points 4 and 10:
On Mac (haven't checked what this looks like on Windows yet), with a bit of fidgeting in the cell, the scrollbar or resize occurs again - will look at what we can do here.

@Stephen-Gates Stephen-Gates modified the milestones: v0.9.0, v0.10.0 Feb 1, 2018
@Stephen-Gates Stephen-Gates added the status:In-progress We're working on this right now label Feb 12, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.10.0, v0.12.0 Feb 14, 2018
@Stephen-Gates Stephen-Gates removed the status:In-progress We're working on this right now label Feb 14, 2018
@ghost ghost closed this as completed in 9f90f6b Mar 13, 2018
@ghost
Copy link

ghost commented Mar 14, 2018

Hi @Stephen-Gates
The issue for the side navigation panel not immediately showing toolbars seems OK to me now.
However, still to handle the bottom covering content (didn't make it in the release :( )

@ghost ghost reopened this Mar 14, 2018
@Stephen-Gates
Copy link
Contributor Author

Thanks @mattRedBox. Do you want to close this and open another issue or leave as is?

@ghost ghost added est:Major Major effort to implement and removed est:Minor Minor effort to implement labels Mar 27, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, v0.18.0 Apr 14, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.18.0, Backlog May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Major Major effort to implement f:Feature-request This issue is a request for a new feature fn:Interface priority:Medium
Projects
None yet
Development

No branches or pull requests

1 participant