Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QueryCount acts differently depending on whether $objOptionalClauses is an array or a QQClause #100

Closed
abePdIta opened this issue Jan 25, 2013 · 3 comments
Closed

QueryCount acts differently depending on whether $objOptionalClauses is an array or a QQClause #100

abePdIta opened this issue Jan 25, 2013 · 3 comments
Labels
bug
Milestone
2.2.1 Release

Comments

@abePdIta
Copy link

Unlike BuildQueryStatement, QueryCount works properly only if $ objOptionalClauses is an array. The problem is in the line "if ($ objOptionalClauses) foreach ($ objOptionalClauses as $ objClause) {".
@scottux
Copy link
Member

scottux commented Feb 2, 2013

Do you think it would be beneficial to wrap objOptionalClause in an array if it isn't already? Or shuold we look a bit deeper?

@abePdIta
Copy link
Author

abePdIta commented Feb 2, 2013

I think the solution you propose is the right one.

olegabr added a commit to olegabr/qcubed that referenced this issue Feb 26, 2013
@olegabr
Fix for qcubed#100 issue
2ab08ea 
The same behavior as in the BuildQueryStatement function is implemented for the QueryCount function.
Unit test is added for the QueryCount function.
@olegabr
Copy link
Member

olegabr commented Feb 26, 2013

fixed in #147

@olegabr olegabr closed this as completed Feb 26, 2013
olegabr added a commit to olegabr/qcubed that referenced this issue Feb 28, 2013
@olegabr
Fix for wrong test in issue qcubed#100
41df4b9
@olegabr olegabr mentioned this issue Mar 4, 2013
Merged
spekary added a commit that referenced this issue Mar 4, 2013
@spekary
Merge pull request #147 from olegabr/bug-100
f64e32c 
Fix for #100 issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.2.1 Release
Development

No branches or pull requests
3 participants
@scottux @olegabr @abePdIta