Make functions accept StateVector in addition to Numpy array

[kevinsung]

Now that the StateVector class exists, functions that accept vec as a Numpy array should be updated to also accept a StateVector, in which norb and nelec don't also need to be passed.

See sample_state_vector for an example of how to support both input types.

Non-exhaustive list of affected modules:

• gates/
• protocols/

[tsmanral]

Hi @kevinsung. Does this issue still exists since this is a very old Issue? If yes, I'd like to assign it to myself and contribute. Please let me know.

[kevinsung]

Hi @kevinsung. Does this issue still exists since this is a very old Issue? If yes, I'd like to assign it to myself and contribute. Please let me know.

@tsmanral Yes, this issue still exists. For an example in the gates module, apply_orbital_rotation still only accepts a Numpy array, and should be update to support StateVector:

ffsim/python/ffsim/gates/orbital_rotation.py

Line 45 in 72fe5c3

vec: np.ndarray,

Note that StateVector now has an __array__ method, so many Numpy functions should work on it directly.

There's no need for me to assign the issue to you. Feel free to go ahead and open a pull request!

[tsmanral]

Thank you @kevinsung. I've forked this repo: https://github.com/tsmanral/ffsim/tree/fix-accpt-StateVector and will create a PR to the main after I update it with StateVectors.