Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move measurements after verbatim box #187

Merged
merged 9 commits into from
Aug 5, 2024
Merged

Move measurements after verbatim box #187

merged 9 commits into from
Aug 5, 2024

Conversation

speller26
Copy link
Collaborator

Summary

Details and comments

rmshaffer
rmshaffer approved these changes Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@rmshaffer rmshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approving to unblock merge. One comment on the add_equivalences() call, but if there's a reason we can't move it then feel free to ignore.

@speller26 speller26 merged commit 2b09a3f into main Aug 5, 2024
7 checks passed
@speller26 speller26 deleted the measure branch August 5, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmshaffer rmshaffer rmshaffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@speller26 @rmshaffer