Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-Commit Hook #874

Closed
cdelnano opened this issue Nov 8, 2022 · 1 comment
Closed

Pre-Commit Hook #874

cdelnano opened this issue Nov 8, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@cdelnano
Copy link
Collaborator

cdelnano commented Nov 8, 2022

Information

  • Qiskit Metal version: Latest as of 11/8
  • Python version: 3.1
  • Operating system: Mac

What is the current behavior?

The pre-commit hook looks at BOTH .py and .ipynb files.

Steps to reproduce the problem

I tried to delete a .ipynb file that was no longer needed, and the yapf formatting raised an error when I tried to commit this change.

What is the expected behavior?

The pre-commit hook should only look at .py files, not .ipynb files.

Suggested solutions

Modify the pre-commit hook so that it only looks at .py files, not .ipynb files.

@cdelnano cdelnano added the bug Something isn't working label Nov 8, 2022
This was referenced Nov 9, 2022
@priti-ashvin-shah-ibm
Copy link
Collaborator

Merged, should be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants