Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ts lib dep #22

Closed
wants to merge 1 commit into from
Closed

fix: add ts lib dep #22

wants to merge 1 commit into from

Conversation

BelfordZ
Copy link

@BelfordZ BelfordZ commented Apr 1, 2019

No description provided.

@antongolub
Copy link
Member

antongolub commented Apr 1, 2019

Hi, @BelfordZ

Could you add a bit more details about the problem?

tslib is already present in package.json / yarn.lock as dev dependency.

@BelfordZ
Copy link
Author

BelfordZ commented Apr 1, 2019

hey @antongolub

I just installed this package and was getting 'cannot find module tslib' when running node_modules/.bin/semantic-release --dry-run

@antongolub
Copy link
Member

Ah, I see...

import * as tslib_1 from "tslib";

@antongolub antongolub closed this in 7283bfa Apr 1, 2019
qiwibot added a commit that referenced this pull request Apr 1, 2019
## [1.6.2](v1.6.1...v1.6.2) (2019-04-01)

### Bug Fixes

* **package:** tslib is required dep ([7283bfa](7283bfa)), closes [#22](#22)
@qiwibot
Copy link
Member

qiwibot commented Apr 1, 2019

🎉 This issue has been resolved in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@antongolub
Copy link
Member

antongolub commented Apr 1, 2019

@BelfordZ, btw, be careful with dry-run. The current version does not handle this param, issue #18
UPD: forget, it's already ok.

@BelfordZ
Copy link
Author

BelfordZ commented Apr 1, 2019

Thanks @antongolub for the quick response. <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants