From f1700e8b55cde5fd3e5e8d0dae44a95abcfea4dc Mon Sep 17 00:00:00 2001 From: Dane Skalski Date: Fri, 6 Jan 2023 11:31:27 -0800 Subject: [PATCH] Complete suggested changes --- keyboards/junco/README.md | 2 +- keyboards/junco/config.h | 5 ----- keyboards/junco/junco.h | 1 - keyboards/junco/keymaps/via/README.md | 3 --- keyboards/junco/rev1/config.h | 9 +-------- keyboards/junco/rev1/post_config.h | 8 +------- keyboards/junco/rev1/rev1.h | 4 ---- 7 files changed, 3 insertions(+), 29 deletions(-) delete mode 100644 keyboards/junco/config.h delete mode 100644 keyboards/junco/keymaps/via/README.md delete mode 100644 keyboards/junco/rev1/rev1.h diff --git a/keyboards/junco/README.md b/keyboards/junco/README.md index 785454ed0b8b..121ef4aef26b 100644 --- a/keyboards/junco/README.md +++ b/keyboards/junco/README.md @@ -1,6 +1,6 @@ # Junco -![Junco](https://github.com/Daneski13/Junco/raw/main/img/Junco.webp) +![Junco](https://i.imgur.com/WzZaIgQ.jpg) Junco is a 60% Raspberry Pi Pico powered split keyboard boasting a 4x6 layout with an aggressive columnar stagger. It has 5 "thumb" keys on either side, support for 2-4 rotary encoders, and per-key RGB lighting. diff --git a/keyboards/junco/config.h b/keyboards/junco/config.h deleted file mode 100644 index 7728e9ec93e3..000000000000 --- a/keyboards/junco/config.h +++ /dev/null @@ -1,5 +0,0 @@ -// Copyright 2022 Dane Skalski (@Daneski13) -// SPDX-License-Identifier: GPL-2.0-or-later - -#pragma once -#include "config_common.h" diff --git a/keyboards/junco/junco.h b/keyboards/junco/junco.h index 307fac504a8e..e1e41daa3fdb 100644 --- a/keyboards/junco/junco.h +++ b/keyboards/junco/junco.h @@ -4,7 +4,6 @@ #pragma once #include "quantum.h" -#include "rev1.h" typedef union { uint32_t raw; diff --git a/keyboards/junco/keymaps/via/README.md b/keyboards/junco/keymaps/via/README.md deleted file mode 100644 index 03efb18e953a..000000000000 --- a/keyboards/junco/keymaps/via/README.md +++ /dev/null @@ -1,3 +0,0 @@ -# VIA Junco Keymap - -The VIA keymap is identical to the [default keymap](../default/README.md), but has VIA enabled for use with the [VIA](https://caniusevia.com/) configurator. diff --git a/keyboards/junco/rev1/config.h b/keyboards/junco/rev1/config.h index 80e4f7ace1f0..d9c0556cdfec 100644 --- a/keyboards/junco/rev1/config.h +++ b/keyboards/junco/rev1/config.h @@ -3,10 +3,6 @@ #pragma once -// Key matrix size (Rows are doubled-up for split) -#define MATRIX_ROWS 10 -#define MATRIX_COLS 6 - // Electrical Wiring Stuff #define MATRIX_ROW_PINS \ { GP8, GP9, GP10, GP11, GP12 } @@ -16,7 +12,6 @@ // Split Keyboard Stuff #define EE_HANDS // Sets the keyboard’s handedness using EEPROM -#define SPLIT_USB_DETECT // USB Detection to decide which side is "master" #define SERIAL_USART_FULL_DUPLEX // Use full duplex communication (TRRS) #define SERIAL_USART_TX_PIN GP0 // USART TX pin #define SERIAL_USART_RX_PIN GP1 // USART RX pin @@ -25,9 +20,7 @@ #ifdef RGB_MATRIX_ENABLE # define RGB_DI_PIN GP15 // Pin for RGB logic -# define RGBLED_NUM 74 // Number of LEDs -# define DRIVER_LED_TOTAL RGBLED_NUM -# define RGB_MATRIX_LED_COUNT RGBLED_NUM +# define RGB_MATRIX_LED_COUNT 74 # define RGB_MATRIX_SPLIT \ { 37, 37 } // 37 LEDs on each side diff --git a/keyboards/junco/rev1/post_config.h b/keyboards/junco/rev1/post_config.h index 2068ac51b60e..a3a0aa2d2cc5 100644 --- a/keyboards/junco/rev1/post_config.h +++ b/keyboards/junco/rev1/post_config.h @@ -2,13 +2,7 @@ // SPDX-License-Identifier: GPL-2.0-or-later /* Default Bootmagic lite */ -// Top left for left side -#ifndef BOOTMAGIC_LITE_ROW -# define BOOTMAGIC_LITE_ROW 0 -#endif -#ifndef BOOTMAGIC_LITE_COLUMN -# define BOOTMAGIC_LITE_COLUMN 0 -#endif +// Top left for left side is default in core // Top right for right side #ifndef BOOTMAGIC_LITE_ROW_RIGHT diff --git a/keyboards/junco/rev1/rev1.h b/keyboards/junco/rev1/rev1.h deleted file mode 100644 index 41ecfea13bc4..000000000000 --- a/keyboards/junco/rev1/rev1.h +++ /dev/null @@ -1,4 +0,0 @@ -// Copyright 2022 Dane Skalski (@Daneski13) -// SPDX-License-Identifier: GPL-2.0-or-later - -#pragma once